Last Comment Bug 736660 - compilation fails: 'source' is not a member of 'nsGkAtoms', if MOZ_MEDIA is not set
: compilation fails: 'source' is not a member of 'nsGkAtoms', if MOZ_MEDIA is n...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Audio/Video (show other bugs)
: Trunk
: x86 Linux
: -- normal (vote)
: mozilla14
Assigned To: :aceman
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-16 17:15 PDT by :aceman
Modified: 2012-03-18 13:10 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (2.27 KB, patch)
2012-03-16 17:24 PDT, :aceman
bzbarsky: review+
Details | Diff | Splinter Review

Description :aceman 2012-03-16 17:15:14 PDT
mozilla/content/base/src/nsContentUtils.cpp: In static member function 'static bool nsContentUtils::IsHTMLVoid(nsIAtom*)':
mozilla/content/base/src/nsContentUtils.cpp:1252:20: error: 'source' is not a member of 'nsGkAtoms'
mozilla/content/base/src/nsContentUtils.cpp: In static member function 'static void nsContentUtils::MaybeFireNodeRemoved(nsINode*, nsINode*, nsIDocument*)':
mozilla/content/base/src/nsContentUtils.cpp:3661:142: warning: suggest parentheses around '&&' within '||'
mozilla/content/base/src/nsContentUtils.cpp: In static member function 'static bool nsContentUtils::IsHTMLVoid(nsIAtom*)':
mozilla/content/base/src/nsContentUtils.cpp:1255:1: error: control reaches end of non-void function
gmake[7]: *** [nsContentUtils.o] Error 1
Comment 1 :aceman 2012-03-16 17:24:13 PDT
Created attachment 606800 [details] [diff] [review]
fix
Comment 2 Boris Zbarsky [:bz] (still a bit busy) 2012-03-16 17:32:43 PDT
Comment on attachment 606800 [details] [diff] [review]
fix

r=me
Comment 3 :aceman 2012-03-16 17:34:24 PDT
Thanks!
Comment 5 Phil Ringnalda (:philor) 2012-03-18 13:10:37 PDT
https://hg.mozilla.org/mozilla-central/rev/14cb5acd5b90

Note You need to log in before you can comment on or make changes to this bug.