73669 - XUL boxes do not adhere to box-sizing rules

Status: NEW

(Core :: XUL, defect)

Description

[David Hyatt]

This is a showstopper for Mozilla 1.0.  When objects inside a box specify 
widths and heights, the box *includes* borders and padding in this 
computation.  Therefore the object ends up with a width/height equal to the 
specified size + margins, when it should end up with a width/height equal to 
the specified size + border + padding + margins.

The fix is to change the default computation for boxes to augment preferred, 
min, and max sizes with borders/padding, and to make it obey the box-sizing 
property so that people can still get the old behavior if they want it.

This could have a subtle and far-reaching impact on our skins and our UI, but 
it is a given that as boxes become standardized by the CSS WG that the 
width/height computation will be done this way.  If we don't change it now, 
we'll end up in backwards-compatibility hell post-1.0.

Comment 1

[David Hyatt]

Here's another fun one for ya, arik.

Comment 2

[Hixie (not reading bugmail)]

We should be able to ease the transition by judicious use of -moz-box-sizing
in the xul.css file.

Comment 3

[arik devens]

pushing off

Comment 4

[arik devens]

Attachment: non-working test case to show the problem

Comment 5

[arik devens]

so i've added a test case that doesn't work, and i'm not sure why, if someone
with more xul expertise wants to help out that would be great ;-)

Comment 6

[Peter Trudelle]

->moz 1.0

Comment 7

[David Hyatt]

mine.

Comment 8

[David Hyatt]

This can always be fudged away later as a skin-defined policy.  Not going to 
worry about this for XUL1.0.