B2G SMS: Support type-0 message

RESOLVED FIXED in mozilla14

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: vicamo, Assigned: vicamo)

Tracking

(Blocks: 1 bug)

unspecified
mozilla14
ARM
Gonk (Firefox OS)
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][lang=js])

Attachments

(2 attachments, 8 obsolete attachments)

(Assignee)

Description

5 years ago
According to 3GPP 23.040 section 9.2.3.9, "A short message type 0 indicates that the ME must acknowledge receipt of the short message but shall discard its contents."
(Assignee)

Updated

5 years ago
Blocks: 709564
Whiteboard: [good first bug][lang=js]
(Assignee)

Updated

5 years ago
Blocks: 736710
(Assignee)

Comment 1

5 years ago
There are also three levels of "don't store" throughout the spec and might have to be taken into consideration together. They are:

1) TP-PID: the whole message should be discarded without further handling.
2) DCS MWI(Message Waiting Indication): message should be read and discard after notifying the indication and/or displaying the message content. See bug 736710.
3) In user data header Enhanced Voice Mail Information. See bug 736710.

We should focus on 1) in this issue and provide a way that can be reused in related tasks.
(Assignee)

Updated

5 years ago
Assignee: nobody → vyang
(Assignee)

Comment 2

5 years ago
Created attachment 607491 [details] [diff] [review]
Support Type-0 Message

This change is based on bug 736697, Part 2: Refactor to share methods.
Attachment #607491 - Flags: review?(philipp)
(Assignee)

Comment 3

5 years ago
verified with rev 9ff494dfc9b0 ;)
(Assignee)

Comment 4

5 years ago
Created attachment 609262 [details] [diff] [review]
Support Type-0 Message : V2

1) rebase due to changes in attachment #609252 [details] [diff] [review]
2) now based on bug 736697 part 5
Attachment #607491 - Attachment is obsolete: true
Attachment #607491 - Flags: review?(philipp)
Attachment #609262 - Flags: review?(philipp)
(Assignee)

Updated

5 years ago
Blocks: 736706
(Assignee)

Updated

5 years ago
Depends on: 736697
(Assignee)

Comment 5

5 years ago
Created attachment 609695 [details] [diff] [review]
Part 1: TP-PID sanity checks
Attachment #609695 - Flags: review?(philipp)
(Assignee)

Comment 6

5 years ago
Created attachment 609696 [details] [diff] [review]
Part 2: Support Type-0 Message : V3

rebase due to changes in attachment 609634 [details] [diff] [review] in bug 736697
Attachment #609262 - Attachment is obsolete: true
Attachment #609262 - Flags: review?(philipp)
Attachment #609696 - Flags: review?(philipp)
(Assignee)

Comment 7

5 years ago
Created attachment 610100 [details] [diff] [review]
Part 1: TP-PID sanity checks : V2

accommodate to changes made in bug 736697 attachment 610085 [details] [diff] [review]
Attachment #609695 - Attachment is obsolete: true
Attachment #609695 - Flags: review?(philipp)
Attachment #610100 - Flags: review?(philipp)
(Assignee)

Comment 8

5 years ago
Created attachment 610450 [details] [diff] [review]
Part 1: TP-PID sanity checks : V3

upate comments
Attachment #610100 - Attachment is obsolete: true
Attachment #610100 - Flags: review?(philipp)
Attachment #610450 - Flags: review?(philipp)
(Assignee)

Comment 9

5 years ago
Created attachment 610451 [details] [diff] [review]
Part 2: Support Type-0 Message : V4

update comments
Attachment #609696 - Attachment is obsolete: true
Attachment #609696 - Flags: review?(philipp)
Attachment #610451 - Flags: review?(philipp)
(Assignee)

Comment 10

5 years ago
Created attachment 610477 [details] [diff] [review]
Part 1: TP-PID sanity checks : V4

missing comma
Attachment #610450 - Attachment is obsolete: true
Attachment #610450 - Flags: review?(philipp)
Attachment #610477 - Flags: review?(philipp)
Comment on attachment 610477 [details] [diff] [review]
Part 1: TP-PID sanity checks : V4

Review of attachment 610477 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_worker.js
@@ +3035,5 @@
> +   *
> +   * @return read pid and effective pid.
> +   *
> +   * @see 3GPP TS 23.040 9.2.3.9
> +   */

Instead of an array return value, could this method simply take the msg object and set msg.epid, msg.pid? I think I would prefer that.

r=me with that, unless there's a good reason not do this.
Attachment #610477 - Flags: review?(philipp) → review+
Attachment #610451 - Flags: review?(philipp) → review+
(Assignee)

Comment 12

5 years ago
Created attachment 612790 [details] [diff] [review]
Part 1: TP-PID sanity checks : V5

review comment 11
Attachment #610477 - Attachment is obsolete: true
Attachment #612790 - Flags: review?(philipp)
(Assignee)

Comment 13

5 years ago
Created attachment 612791 [details] [diff] [review]
Part 2: Support Type-0 Message : V5

review comment 11
Attachment #610451 - Attachment is obsolete: true
Attachment #612791 - Flags: review?(philipp)
(Assignee)

Comment 14

5 years ago
(In reply to Philipp von Weitershausen [:philikon] from comment #11)
> Instead of an array return value, could this method simply take the msg
> object and set msg.epid, msg.pid? I think I would prefer that.
> 
> r=me with that, unless there's a good reason not do this.

I agree. That simplifies the patches. Thanks.
Attachment #612790 - Flags: review?(philipp) → review+
Attachment #612791 - Flags: review?(philipp) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d4f1f7d050a
https://hg.mozilla.org/integration/mozilla-inbound/rev/6dffa132f245
https://hg.mozilla.org/mozilla-central/rev/0d4f1f7d050a
https://hg.mozilla.org/mozilla-central/rev/6dffa132f245
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.