73671 - [XUL Syntax] Replace <box> with <hbox> and <box orient|align="vertical"> with <vbox>

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[David Hyatt]

This bug should improve performance a bit, since we'll cut down on the # of 
attributes in our content model.  This change should be made in both the XUL 
and in the XBL.

Comment 1

[Blake Ross]

*** Bug 70857 has been marked as a duplicate of this bug. ***

Comment 2

[[e-mail]]

What happens to <box orient="vertical" autostretch="never" valign="bottom">?

I can't see any CSS that would style a vbox in the same way.

Comment 3

[David Hyatt]

box-pack and box-align will handle the autostretch/valign stuff.  Those are
other bugs.  This bug just covers turning <box orient="vertical"> into <vbox>
while leaving all other attributes alone.

Comment 4

[Mark Olson]

Taking.

<box/> is completely defunct correct?

As to css, should box selectors be changed to just hbox, or should I create a
rule that allows for either orientation?  (box[orient=whatever] is self
explanatory obviously)

Comment 5

[David Hyatt]

I'm more concerned with fixing <box orient="vertical"> to be <vbox>.  YOu don't 
have to eliminate every last <box> unless you're feeling really motivated.

This bug really falls in the category of cleanup rather than syntax changes, 
since I don't plan to deprecate or obsolete the <box> tag or the orient 
attribute.

Comment 6

[Mark Anderson]

I've got a tool I've written in the last two days that will brute-force this 
conversion for the entire tree.  I'd be more than willing to take charge of this 
bug, since I can just roll it into the patch that I'm working on in bug 70857 
(that also fixes two other bugs that are in Bugzilla and a couple of bugs that 
aren't :) ), and I can get the conversion done in about ten minutes (all of 
which is spent just running the .exe).  Since the change I'm making is going to 
require a carpool at the beginning of 0.9.3 (at the earliest) anyway, shall I 
take this one, too?

Comment 7

[Mark Anderson]

I've got a patch for this in bug 70857 that I'm trying to get in at the start of 
0.9.3, so I might as well take it myself.  If this is inappropriate (and, if 
so, I apologize), feel free to reset as necessary.

Comment 8

[Mark Anderson]

Fix checked in to trunk on July 9.  <box> is still supported, of course, but all 
instances have been changed to <hbox> or <vbox>, modulo those affected by bug 
88332.