Fix the includes in layout/svg/base/src so that we can stop including nsSVGSVGElement.h in nsSVGContainerFrame.h

RESOLVED FIXED in mozilla14

Status

()

Core
SVG
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

Trunk
mozilla14
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 606885 [details] [diff] [review]
patch

There is no need for nsSVGContainerFrame.h to include nsSVGSVGElement.h. It unnecessarily slows down compile time by including unnecessary things, and it is preventing me adding layout/svg/base/src to LOCAL_INCLUDES in layout/generic/Makefile.in in the patch in bug 379709 without also adding content/svg/content/src. I plan to do some work soon to properly clean up the includes in layout/svg, but for now this cleans things up sufficiently to allow me to land the patch in bug 379709.
Attachment #606885 - Flags: review?(longsonr)
(Assignee)

Updated

6 years ago
Summary: Stop including nsSVGSVGElement.h in nsSVGContainerFrame.h → Fix the includes in layout/svg/base/src so that we can stop including nsSVGSVGElement.h in nsSVGContainerFrame.h
(Assignee)

Comment 1

6 years ago
The files where I've added includes for nsSVGUtils.h need that now for NS_STATE_SVG_NONDISPLAY_CHILD since they are no longer getting it included indirectly via nsSVGSVGElement.h.

Updated

6 years ago
Attachment #606885 - Flags: review?(longsonr) → review+
https://hg.mozilla.org/mozilla-central/rev/b3142bc739d8
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.