Last Comment Bug 736802 - Qt EGL Maemo compilation broken
: Qt EGL Maemo compilation broken
Status: RESOLVED FIXED
: regression
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: ARM Linux
: -- normal (vote)
: mozilla14
Assigned To: Oleg Romashin (:romaxa)
:
Mentors:
Depends on:
Blocks: 732865
  Show dependency treegraph
 
Reported: 2012-03-17 22:33 PDT by Oleg Romashin (:romaxa)
Modified: 2012-03-22 06:41 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Declare native types (941 bytes, patch)
2012-03-17 22:36 PDT, Oleg Romashin (:romaxa)
no flags Details | Diff | Review
Fix regression for EGL building on Maemo/N9 (1.56 KB, patch)
2012-03-20 13:47 PDT, Oleg Romashin (:romaxa)
joe: review+
Details | Diff | Review
Fix regression for EGL building on Maemo/N9 (3.03 KB, patch)
2012-03-20 19:29 PDT, Oleg Romashin (:romaxa)
romaxa: review+
Details | Diff | Review

Description Oleg Romashin (:romaxa) 2012-03-17 22:33:00 PDT
In qws configuration (without X11) compilation of GLLibraryEGL.h is broken.
EGLNativeWindowType and other native types not defined
Comment 1 Oleg Romashin (:romaxa) 2012-03-17 22:36:17 PDT
Created attachment 606936 [details] [diff] [review]
Declare native types
Comment 2 Oleg Romashin (:romaxa) 2012-03-20 13:47:21 PDT
Created attachment 607699 [details] [diff] [review]
Fix regression for EGL building on Maemo/N9
Comment 3 Joe Drew (not getting mail) 2012-03-20 14:07:53 PDT
Comment on attachment 607699 [details] [diff] [review]
Fix regression for EGL building on Maemo/N9

Review of attachment 607699 [details] [diff] [review]:
-----------------------------------------------------------------

r=me if it passes try
Comment 4 Oleg Romashin (:romaxa) 2012-03-20 19:29:22 PDT
Created attachment 607838 [details] [diff] [review]
Fix regression for EGL building on Maemo/N9

Ok, this is little bit breaking win build, reorganized it in order to avoid double declaration
Comment 5 Oleg Romashin (:romaxa) 2012-03-21 14:00:05 PDT
Comment on attachment 607838 [details] [diff] [review]
Fix regression for EGL building on Maemo/N9

23:58 < gw280> romaxa: great, r+ from me
Comment 6 Marco Bonardo [::mak] 2012-03-22 06:41:04 PDT
https://hg.mozilla.org/mozilla-central/rev/73e62d29b083

Note You need to log in before you can comment on or make changes to this bug.