Status
()
People
(Reporter: dao, Assigned: dao)
Tracking
Firefox Tracking Flags
(firefox12 unaffected, firefox13 verified)
Details
(Whiteboard: [qa!])
Attachments
(1 attachment, 1 obsolete attachment)
|
1.44 KB,
patch
|
mak
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
| Comment hidden (empty) |
|
(Assignee) | |
Comment 1•7 years ago
|
||
Created attachment 606972 [details] [diff] [review] patch
Attachment #606972 -
Flags: review?(mak77)
|
|
(Assignee) | |
Comment 2•7 years ago
|
||
Created attachment 606973 [details] [diff] [review] patch v2 Hm, I guess the restorePreviousSession icon should also have the width specified?
Attachment #606972 -
Attachment is obsolete: true
Attachment #606972 -
Flags: review?(mak77)
Attachment #606973 -
Flags: review?(mak77)
|
||
Comment 3•7 years ago
|
||
Comment on attachment 606973 [details] [diff] [review] patch v2 Review of attachment 606973 [details] [diff] [review]: ----------------------------------------------------------------- Well, in the restorePreviousSession case, the label is never below the button, so it's unlikely height is needed for this specific bug. Though, I assume since the whole button moves down, it's worth to have it, to do proper calculation earlier. Is there any other reason for it I'm missing?
Attachment #606973 -
Flags: review?(mak77) → review+
|
|
(Assignee) | |
Comment 4•7 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/307490794b3d
Target Milestone: --- → Firefox 14
|
|
(Assignee) | |
Updated•7 years ago
|
Attachment #606973 -
Flags: approval-mozilla-aurora?
|
|
(Assignee) | |
Updated•7 years ago
|
status-firefox12: --- → unaffected
status-firefox13: --- → affected
|
||
Comment 5•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/307490794b3d
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
|
||
Comment 6•7 years ago
|
||
Comment on attachment 606973 [details] [diff] [review] patch v2 [Triage Comment] Low risk patch in support of correctness in a new feature. Approved for Aurora 13.
Attachment #606973 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
(Assignee) | |
Comment 7•7 years ago
|
||
http://hg.mozilla.org/releases/mozilla-aurora/rev/a0497708403a
status-firefox13: affected → fixed
|
||
Updated•7 years ago
|
Whiteboard: [qa+]
I've loaded the about:home page in Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20100101 Firefox/13.0 beta 4 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:13.0) Gecko/20100101 Firefox/13.0 beta 4 The buttons did not jerk as the site was loading. There are other steps in verifying this? Thanks
|
|
||
Comment 9•7 years ago
|
||
(In reply to Vlad [QA] from comment #8) > The buttons did not jerk as the site was loading. > There are other steps in verifying this? > > Thanks I think that's good enough.
status-firefox13: fixed → verified
Whiteboard: [qa+] → [qa!]
You need to log in
before you can comment on or make changes to this bug.