736846 - about:home launcher buttons jerk down as the icons load

Status: RESOLVED FIXED

Description

[Dão Gottwald [::dao]]

Comment 1

[Dão Gottwald [::dao]]

Created attachment 606972 [details] [diff] [review]
patch

Comment 2

[Dão Gottwald [::dao]]

Created attachment 606973 [details] [diff] [review]
patch v2

Hm, I guess the restorePreviousSession icon should also have the width specified?

Comment 3

[Marco Bonardo [::mak]]

Comment on attachment 606973 [details] [diff] [review]
patch v2

Review of attachment 606973 [details] [diff] [review]:
-----------------------------------------------------------------

Well, in the restorePreviousSession case, the label is never below the button, so it's unlikely height is needed for this specific bug.  Though, I assume since the whole button moves down, it's worth to have it, to do proper calculation earlier.  Is there any other reason for it I'm missing?

Comment 4

[Dão Gottwald [::dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/307490794b3d

Comment 5

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/307490794b3d

Comment 6

[Alex Keybl [:akeybl]]

Comment on attachment 606973 [details] [diff] [review]
patch v2

[Triage Comment]
Low risk patch in support of correctness in a new feature. Approved for Aurora 13.

Comment 7

[Dão Gottwald [::dao]]

http://hg.mozilla.org/releases/mozilla-aurora/rev/a0497708403a

Comment 8

[Vlad [QA]]

I've loaded the about:home page in
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20100101 Firefox/13.0 beta 4
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:13.0) Gecko/20100101 Firefox/13.0 beta 4

The buttons did not jerk as the site was loading. 
There are other steps in verifying this?

Thanks

Comment 9

[Anthony Hughes (:ashughes) [GFX][QA][Mentor]]

(In reply to Vlad [QA] from comment #8)
> The buttons did not jerk as the site was loading. 
> There are other steps in verifying this?
> 
> Thanks

I think that's good enough.