Closed Bug 736846 Opened 9 years ago Closed 9 years ago

about:home launcher buttons jerk down as the icons load

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 14
Tracking Flags:
Tracking Status
firefox12 --- unaffected
firefox13 --- verified

People

(Reporter: dao, Assigned: dao)

References

Details

(Whiteboard: [qa!])

Attachments

(1 file, 1 obsolete file)

patch v2
1.44 KB, patch
mak
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
No description provided.
Attached patch patch (obsolete) — — Splinter Review
Attachment #606972 - Flags: review?(mak77)
Attached patch patch v2 — — Splinter Review 
Hm, I guess the restorePreviousSession icon should also have the width specified?
Attachment #606972 - Attachment is obsolete: true
Attachment #606972 - Flags: review?(mak77)
Attachment #606973 - Flags: review?(mak77)
Comment on attachment 606973 [details] [diff] [review]
patch v2

Review of attachment 606973 [details] [diff] [review]:
-----------------------------------------------------------------

Well, in the restorePreviousSession case, the label is never below the button, so it's unlikely height is needed for this specific bug.  Though, I assume since the whole button moves down, it's worth to have it, to do proper calculation earlier.  Is there any other reason for it I'm missing?
Attachment #606973 - Flags: review?(mak77) → review+
Attachment #606973 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/307490794b3d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 606973 [details] [diff] [review]
patch v2

[Triage Comment]
Low risk patch in support of correctness in a new feature. Approved for Aurora 13.
Attachment #606973 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Whiteboard: [qa+]
I've loaded the about:home page in
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20100101 Firefox/13.0 beta 4
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:13.0) Gecko/20100101 Firefox/13.0 beta 4

The buttons did not jerk as the site was loading. 
There are other steps in verifying this?

Thanks
(In reply to Vlad [QA] from comment #8)
> The buttons did not jerk as the site was loading. 
> There are other steps in verifying this?
> 
> Thanks

I think that's good enough.
status-firefox13: fixed → verified
Whiteboard: [qa+] → [qa!]
You need to log in before you can comment on or make changes to this bug.