Closed Bug 736882 Opened 12 years ago Closed 7 years ago

Request/response details should indicate whether SPDY was used

Categories

(DevTools :: Netmonitor, defect, P3)

defect

Tracking

(firefox55 fixed)

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: jruderman, Assigned: vkatsikaros)

References

Details

(Keywords: dev-doc-needed, good-first-bug, Whiteboard: [spdy])

Attachments

(2 files)

1. Open the Web Console to the Net panel.
2. Load https://www.google.com/.
3. Click one of the requests.

Result: An "Inspect Network Request" window appears, but it does not indicate whether SPDY was used.
Actually, there is one. If you see the X-Firefox-Spdy header in the response, it means that it was processed through SPDY.
Yep, there is a way to spot SPDY requests presently, but it could certainly be clearer.
Whiteboard: [spdy]
Moving this over to the netmonitor tool.
Component: Developer Tools: Console → Developer Tools: Netmonitor
OS: Mac OS X → All
Hardware: x86_64 → All
Summary: "Inspect Network Request" should indicate whether SPDY was used → Request/response details should indicate whether SPDY was used
Dupe of bug 859049 maybe?
(In reply to Victor Porof [:vp] from comment #4)
> Dupe of bug 859049 maybe?

That is the protocol (http, https, ftp, etc). Isn't SPDY something different? Related to how data is transported.
It is most useful to think of spdy as a version of HTTP. (i.e. HTTP/1.0 HTTP/1.1, spdy/2, spdy/3 are all effectively variations of HTTP).

fwiw HTTPs is not a different protocol, it is a different scheme. (spdy doesn't have its own scheme). It is some version of HTTP over some version of SSL. All of those version #'s would be interesting information in the developer console.
Patrick, thank you for the explanation.

Marking this bug as a dependency of bug 859049. Victor, I'm keeping this bug open such that we do not forget its important for us to fix this. I assume that when we work on 859049 we can fix this bug as well.
Blocks: 859049
Priority: -- → P3
Severity: enhancement → normal
Is the status of this ticket somehow related to https://bugzilla.mozilla.org/show_bug.cgi?id=1287132 ?
The new "Protocol" column suggested in bug 1345489 should indicate whether SPDY is used.
Marking this one as duplicate.

Honza
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
The new Protocol doesn't display SPDY, should we reopen ?
Flags: needinfo?(odvarko)
Status: RESOLVED → REOPENED
Flags: needinfo?(odvarko)
Resolution: DUPLICATE → ---
Honza, I apologize for missing everything else apart httpVersion for the protocol column. If I understand correctly I understand URL.protocol returns "scheme:", so playing with the url of the request doesn't help tp get the protocol. I grep'ed for spdy in devtools but I didn't spot something. I would like to ask for hints on identifying spdy for the request?
Flags: needinfo?(odvarko)
(In reply to Vangelis Katsikaros from comment #11)
> Honza, I apologize for missing everything else apart httpVersion for the
> protocol column. If I understand correctly I understand URL.protocol returns
> "scheme:", so playing with the url of the request doesn't help tp get the
> protocol. I grep'ed for spdy in devtools but I didn't spot something. I
> would like to ask for hints on identifying spdy for the request?

You can check for the X-Firefox-Spdy response header
(In reply to Tim Nguyen :ntim (not accepting requests until 1st June) from comment #12)
> You can check for the X-Firefox-Spdy response header
Yep, that's what I have in mind too.

Honza
Flags: needinfo?(odvarko)
Assignee: nobody → vkatsikaros
Status: REOPENED → ASSIGNED
Attached image protocol_demo.png
Comment on attachment 8871391 [details]
Bug 736882 - Request/response details should indicate whether SPDY was used.

https://reviewboard.mozilla.org/r/142870/#review146824

Looks reasonable to me.

R+ assuming try is green.

Thanks for working on this!

Honza
Attachment #8871391 - Flags: review?(odvarko) → review+
Keywords: dev-doc-needed
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/70fa0a9a7f6f
Request/response details should indicate whether SPDY was used. r=Honza
https://hg.mozilla.org/mozilla-central/rev/70fa0a9a7f6f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.