736882 - Request/response details should indicate whether SPDY was used

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[Jesse Ruderman]

1. Open the Web Console to the Net panel.
2. Load https://www.google.com/.
3. Click one of the requests.

Result: An "Inspect Network Request" window appears, but it does not indicate whether SPDY was used.

Comment 1

[Jo Hermans]

Actually, there is one. If you see the X-Firefox-Spdy header in the response, it means that it was processed through SPDY.

Comment 2

[Kevin Dangoor]

Yep, there is a way to spot SPDY requests presently, but it could certainly be clearer.

Comment 3

[Mihai Sucan [:msucan]]

Moving this over to the netmonitor tool.

Comment 4

[Victor Porof [:vporof][:vp]]

Dupe of bug 859049 maybe?

Comment 5

[Mihai Sucan [:msucan]]

(In reply to Victor Porof [:vp] from comment #4)
> Dupe of bug 859049 maybe?

That is the protocol (http, https, ftp, etc). Isn't SPDY something different? Related to how data is transported.

Comment 6

[Patrick McManus [:mcmanus]]

It is most useful to think of spdy as a version of HTTP. (i.e. HTTP/1.0 HTTP/1.1, spdy/2, spdy/3 are all effectively variations of HTTP).

fwiw HTTPs is not a different protocol, it is a different scheme. (spdy doesn't have its own scheme). It is some version of HTTP over some version of SSL. All of those version #'s would be interesting information in the developer console.

Comment 7

[Mihai Sucan [:msucan]]

Patrick, thank you for the explanation.

Marking this bug as a dependency of bug 859049. Victor, I'm keeping this bug open such that we do not forget its important for us to fix this. I assume that when we work on 859049 we can fix this bug as well.

Comment 8

[Vangelis Katsikaros]

Is the status of this ticket somehow related to https://bugzilla.mozilla.org/show_bug.cgi?id=1287132 ?

Comment 9

[Jan Honza Odvarko [:Honza] (always need-info? me)]

The new "Protocol" column suggested in bug 1345489 should indicate whether SPDY is used.
Marking this one as duplicate.

Honza

Comment 10

[Tim Nguyen :ntim]

The new Protocol doesn't display SPDY, should we reopen ?

Comment 11

[Vangelis Katsikaros]

Honza, I apologize for missing everything else apart httpVersion for the protocol column. If I understand correctly I understand URL.protocol returns "scheme:", so playing with the url of the request doesn't help tp get the protocol. I grep'ed for spdy in devtools but I didn't spot something. I would like to ask for hints on identifying spdy for the request?

Comment 12

[Tim Nguyen :ntim]

(In reply to Vangelis Katsikaros from comment #11)
> Honza, I apologize for missing everything else apart httpVersion for the
> protocol column. If I understand correctly I understand URL.protocol returns
> "scheme:", so playing with the url of the request doesn't help tp get the
> protocol. I grep'ed for spdy in devtools but I didn't spot something. I
> would like to ask for hints on identifying spdy for the request?

You can check for the X-Firefox-Spdy response header

Comment 13

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Tim Nguyen :ntim (not accepting requests until 1st June) from comment #12)
> You can check for the X-Firefox-Spdy response header
Yep, that's what I have in mind too.

Honza

Comment 14

[Vangelis Katsikaros]

Attachment: Bug 736882 - Request/response details should indicate whether SPDY was used.

Review commit: https://reviewboard.mozilla.org/r/142870/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/142870/

Comment 15

[Vangelis Katsikaros]

Attachment: protocol_demo.png

Comment 16

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8871391 [details]
Bug 736882 - Request/response details should indicate whether SPDY was used.

https://reviewboard.mozilla.org/r/142870/#review146824

Looks reasonable to me.

R+ assuming try is green.

Thanks for working on this!

Honza

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/70fa0a9a7f6f
Request/response details should indicate whether SPDY was used. r=Honza

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/70fa0a9a7f6f