Suppress warning warning C4355: 'this' : used in base member initializer list in nsHttpChannel::nsHttpChannel

RESOLVED FIXED in mozilla14

Status

()

Core
Networking: HTTP
--
trivial
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: briansmith, Assigned: briansmith)

Tracking

Trunk
mozilla14
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning])

Attachments

(1 attachment)

Created attachment 607022 [details] [diff] [review]
Suppress warning warning C4355: 'this' : used in base member initializer list in nsHttpChannel::nsHttpChannel

I verified that HttpAsyncAborter's constructor does not dereference the passed-in pointer.
Attachment #607022 - Flags: review?(cbiesinger)
Comment on attachment 607022 [details] [diff] [review]
Suppress warning warning C4355: 'this' : used in base member initializer list in nsHttpChannel::nsHttpChannel

Review of attachment 607022 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/protocol/http/nsHttpChannel.cpp
@@ +69,5 @@
>  #include "mozilla/Telemetry.h"
>  #include "nsDOMError.h"
>  #include "nsAlgorithm.h"
>  #include "sampler.h"
> +#include "base/compiler_specific.h"

I'm a little leery about depending too much on the chromium IPC headers; it'd be better if something similar to ALLOW_THIS_IN_INITIALIZER_LIST was added to MFBT first.  There are certainly other places that could benefit from it.
Attachment #607022 - Flags: review?(cbiesinger) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/6348b1ae1f85
Target Milestone: --- → mozilla14
http://hg.mozilla.org/mozilla-central/rev/6348b1ae1f85
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.