73690 - nsWebBrowserPersist should munge src= attributes to relative paths

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Judson Valeski]

Our current implementation generates absolute urls for src= attributes when we
should be using relative (for transportability reasons).

Comment 1

[Adam Lock]

All the code for saving out the new URL is in 
nsWebBrowserPersist::FixupNodeAttribute. It should be possible to modify this to 
use relative paths.

Comment 2

[Adam Lock]

Attachment: Work in progress patch for relative URLs. Notes follow

Comment 3

[Adam Lock]

I have a patch for the relative files problem but it exposes a problem which the 
BASE tag which must be resolved before it is complete.

The problem is that if a document contains a <BASE> element then all relative 
URLS to files will be resolved to that address and not onto the file path. I've 
commented out the lines that insert a BASE tag but it means relative anchor 
links in the page do not work.

To make relative files and anchors both work. I will have to change the fix up 
code so that the BASE tag is removed and all relative links are made into 
absolute ones.

Comment 4

[Adam Lock]

Attachment: Relative files and anchors both working. BASE issue sorted out.

Comment 5

[Adam Lock]

Attachment: Slightly updated. Fixes IMAGE and AREA links to be absolute too

Comment 6

[Adam Lock]

Attachment: Adds support for background attribute on BODY tag (bug 74420)

Comment 7

[rpotts (gone)]

These changes look good... (r=rpotts)

-- rick

Comment 8

[Christopher Blizzard (:blizzard)]

looks fine to me too, sr=blizzard

Comment 9

[Adam Lock]

Fix is checked in

Comment 10

[Michael Dunn]

Correction: Changing QA contact for the Embed API bugs to David Epstein.

Comment 11

[David Epstein]

changed QA contact to dsirnapalli. He's looking at this interface.

Comment 12

[dsirnapalli]

-- marking as verified.