Closed
Bug 736902
Opened 13 years ago
Closed 13 years ago
Remove support for unused SetSwapRectangleANDROID symbol
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: mwu, Assigned: mwu)
References
Details
Attachments
(1 file)
|
2.30 KB,
patch
|
gal
:
review+
|
Details | Diff | Splinter Review |
We never used this, and all this does is make egl libraries without it fail to load.
Attachment #607034 -
Flags: review?(jones.chris.g)
|
||
Comment 1•13 years ago
|
||
Should we support it though? Not opposed to removing it for now but I would like to understand whether this was dropped in 4.0 or we just don't support it right.
|
|
||
Updated•13 years ago
|
Attachment #607034 -
Flags: review?(jones.chris.g) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
(In reply to Andreas Gal :gal from comment #1)
> Should we support it though? Not opposed to removing it for now but I would
> like to understand whether this was dropped in 4.0 or we just don't support
> it right.
The surfaceflinger code talks about how this is slow so we probably don't want support for it. https://github.com/cgjones/android-frameworks-base/blob/gingerbread-b2g/services/surfaceflinger/DisplayHardware/DisplayHardware.cpp#L241 Apparently using setUpdateRectangle looks the preferred solution, but I don't know how it improves things.
|
|
||
Comment 3•13 years ago
|
||
Great. Land it! :)
|
|
Assignee | |
Comment 4•13 years ago
|
||
Target Milestone: --- → mozilla14
|
||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Version: unspecified → Trunk
|
|
||
Comment 6•13 years ago
|
||
++mounir
You need to log in
before you can comment on or make changes to this bug.
Description
•