The default bug view has changed. See this FAQ.

Remove support for unused SetSwapRectangleANDROID symbol

RESOLVED FIXED in mozilla14

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mwu, Assigned: mwu)

Tracking

Trunk
mozilla14
All
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 607034 [details] [diff] [review]
Remove SetSwapRectangleANDROID

We never used this, and all this does is make egl libraries without it fail to load.
Attachment #607034 - Flags: review?(jones.chris.g)
(Assignee)

Updated

5 years ago
Blocks: 736901

Comment 1

5 years ago
Should we support it though? Not opposed to removing it for now but I would like to understand whether this was dropped in 4.0 or we just don't support it right.

Updated

5 years ago
Attachment #607034 - Flags: review?(jones.chris.g) → review+
(Assignee)

Comment 2

5 years ago
(In reply to Andreas Gal :gal from comment #1)
> Should we support it though? Not opposed to removing it for now but I would
> like to understand whether this was dropped in 4.0 or we just don't support
> it right.

The surfaceflinger code talks about how this is slow so we probably don't want support for it. https://github.com/cgjones/android-frameworks-base/blob/gingerbread-b2g/services/surfaceflinger/DisplayHardware/DisplayHardware.cpp#L241 Apparently using setUpdateRectangle looks the preferred solution, but I don't know how it improves things.

Comment 3

5 years ago
Great. Land it! :)
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/93ea6c992e17
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/93ea6c992e17
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Version: unspecified → Trunk

Comment 6

5 years ago
++mounir
You need to log in before you can comment on or make changes to this bug.