Last Comment Bug 736902 - Remove support for unused SetSwapRectangleANDROID symbol
: Remove support for unused SetSwapRectangleANDROID symbol
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: All Gonk (Firefox OS)
: -- normal (vote)
: mozilla14
Assigned To: Michael Wu [:mwu]
:
Mentors:
Depends on:
Blocks: gonk-ics
  Show dependency treegraph
 
Reported: 2012-03-18 16:44 PDT by Michael Wu [:mwu]
Modified: 2012-03-21 03:53 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Remove SetSwapRectangleANDROID (2.30 KB, patch)
2012-03-18 16:44 PDT, Michael Wu [:mwu]
gal: review+
Details | Diff | Review

Description Michael Wu [:mwu] 2012-03-18 16:44:33 PDT
Created attachment 607034 [details] [diff] [review]
Remove SetSwapRectangleANDROID

We never used this, and all this does is make egl libraries without it fail to load.
Comment 1 Andreas Gal :gal 2012-03-18 17:15:05 PDT
Should we support it though? Not opposed to removing it for now but I would like to understand whether this was dropped in 4.0 or we just don't support it right.
Comment 2 Michael Wu [:mwu] 2012-03-18 17:23:09 PDT
(In reply to Andreas Gal :gal from comment #1)
> Should we support it though? Not opposed to removing it for now but I would
> like to understand whether this was dropped in 4.0 or we just don't support
> it right.

The surfaceflinger code talks about how this is slow so we probably don't want support for it. https://github.com/cgjones/android-frameworks-base/blob/gingerbread-b2g/services/surfaceflinger/DisplayHardware/DisplayHardware.cpp#L241 Apparently using setUpdateRectangle looks the preferred solution, but I don't know how it improves things.
Comment 3 Andreas Gal :gal 2012-03-18 17:25:24 PDT
Great. Land it! :)
Comment 5 Mounir Lamouri (:mounir) 2012-03-21 03:51:37 PDT
https://hg.mozilla.org/mozilla-central/rev/93ea6c992e17
Comment 6 Andreas Gal :gal 2012-03-21 03:53:49 PDT
++mounir

Note You need to log in before you can comment on or make changes to this bug.