Created attachment 607035 [details] [diff] [review] Clamp offset passed to OnDataAvailable instead of wrapping it See the documentation: * @param aOffset * Number of bytes that were sent in previous onDataAvailable calls * for this request. In other words, the sum of all previous count * parameters. * If that number is greater than or equal to 2^32, this parameter * will be PR_UINT32_MAX (2^32 - 1). The attached patch clamps the value in the same way that nsInputStreamPump::OnStateTransfer does. Without this patch, MSVC complains about the implicit PRUint64 to PRUint32 conversion when mLogicalOffset is passed to OnDataAvailable.
5 years ago