[SeaMonkey] "a11y/accessible/relations/test_ui_modalprompt.html | Test timed out."
VERIFIED
FIXED
in mozilla14
Status
()
People
(Reporter: sgautherie, Assigned: sgautherie)
Tracking
(Depends on: 1 bug, Blocks: 2 bugs)
Bug Flags:
Firefox Tracking Flags
(Not tracked)
Details
(Whiteboard: [perma-orange], URL)
Attachments
(1 attachment)
|
1.72 KB,
patch
|
surkov
:
review+
surkov
:
feedback+
|
Details | Diff | Splinter Review |
I'm guessing this fails because SeaMonkey bug 625056 is not fixed yet, right?
|
||
Comment 1•7 years ago
|
||
(In reply to Serge Gautherie (:sgautherie) from comment #0) > I'm guessing this fails because SeaMonkey bug 625056 is not fixed yet, right? sounds right
|
(Assignee) | |
Comment 2•7 years ago
|
||
Created attachment 607490 [details] [diff] [review] (Av1) test_ui_modalprompt.html needs to check "prompts.tab_modal.enabled" preference [Checked in: Comment 6] Copied+Adapted existing code to use SpecialPowers.
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #607490 -
Flags: review?(surkov.alexander)
|
|
||
Comment 3•7 years ago
|
||
Comment on attachment 607490 [details] [diff] [review] (Av1) test_ui_modalprompt.html needs to check "prompts.tab_modal.enabled" preference [Checked in: Comment 6] Review of attachment 607490 [details] [diff] [review]: ----------------------------------------------------------------- ::: accessible/tests/mochitest/relations/test_ui_modalprompt.html @@ +80,5 @@ > gQueue.invoke(); // will call SimpleTest.finish() > } > > + if (!hasTabModalPrompts()) { > + todo(false, "Test disabled when tab modal prompts are not enabled."); SimpleTest.finish()? I think I'd prefer if (hasTabModalPrompts()) { } else { }
Attachment #607490 -
Flags: review?(surkov.alexander) → review+
|
|
(Assignee) | |
Comment 4•7 years ago
|
||
Comment on attachment 607490 [details] [diff] [review] (Av1) test_ui_modalprompt.html needs to check "prompts.tab_modal.enabled" preference [Checked in: Comment 6] (In reply to alexander :surkov from comment #3) > SimpleTest.finish()? No: skipping SimpleTest.waitForExplicitFinish() instead. > I think I'd prefer > if (hasTabModalPrompts()) { > } else { > } "I/We" usually handle the "exception" first, but I can swap that code if you insist.
Attachment #607490 -
Flags: feedback?(surkov.alexander)
|
|
||
Comment 5•7 years ago
|
||
(In reply to Serge Gautherie (:sgautherie) from comment #4) > Comment on attachment 607490 [details] [diff] [review] > (Av1) test_ui_modalprompt.html needs to check "prompts.tab_modal.enabled" > preference > > (In reply to alexander :surkov from comment #3) > > > SimpleTest.finish()? > > No: skipping SimpleTest.waitForExplicitFinish() instead. ok, I thought that SimpleTest.finish() is necessary part to finish a test. > > I think I'd prefer > > if (hasTabModalPrompts()) { > > } else { > > } > > "I/We" usually handle the "exception" first, but I can swap that code if you > insist. ok, up to you
|
|
||
Updated•7 years ago
|
Attachment #607490 -
Flags: feedback?(surkov.alexander) → feedback+
|
|
(Assignee) | |
Comment 6•7 years ago
|
||
Comment on attachment 607490 [details] [diff] [review] (Av1) test_ui_modalprompt.html needs to check "prompts.tab_modal.enabled" preference [Checked in: Comment 6] https://hg.mozilla.org/mozilla-central/rev/e97da8b4b939
Attachment #607490 -
Attachment description: (Av1) test_ui_modalprompt.html needs to check "prompts.tab_modal.enabled" preference → (Av1) test_ui_modalprompt.html needs to check "prompts.tab_modal.enabled" preference
[Checked in: Comment 6]
|
|
(Assignee) | |
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Flags: in-testsuite+
Hardware: x86 → All
Resolution: --- → FIXED
|
|
(Assignee) | |
Comment 7•7 years ago
|
||
Ftr, it succeeded as https://tbpl.mozilla.org/?tree=Try&rev=b5edde2abb07
|
||
Comment 8•7 years ago
|
||
Nice.
|
|
(Assignee) | |
Comment 9•7 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1332324425.1332330787.5222.gz Linux comm-central-trunk debug test mochitest-other on 2012/03/21 03:07:05 V.Fixed
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•