736905 - [SeaMonkey] "a11y/accessible/relations/test_ui_modalprompt.html | Test timed out."

Status: VERIFIED FIXED

Description

[Serge Gautherie (:sgautherie)]

I'm guessing this fails because SeaMonkey bug 625056 is not fixed yet, right?

Comment 1

[alexander :surkov]

(In reply to Serge Gautherie (:sgautherie) from comment #0)
> I'm guessing this fails because SeaMonkey bug 625056 is not fixed yet, right?

sounds right

Comment 2

[Serge Gautherie (:sgautherie)]

Created attachment 607490 [details] [diff] [review]
(Av1) test_ui_modalprompt.html needs to check "prompts.tab_modal.enabled" preference
[Checked in: Comment 6]

Copied+Adapted existing code to use SpecialPowers.

Comment 3

[alexander :surkov]

Comment on attachment 607490 [details] [diff] [review]
(Av1) test_ui_modalprompt.html needs to check "prompts.tab_modal.enabled" preference
[Checked in: Comment 6]

Review of attachment 607490 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/tests/mochitest/relations/test_ui_modalprompt.html
@@ +80,5 @@
>        gQueue.invoke(); // will call SimpleTest.finish()
>      }
>  
> +    if (!hasTabModalPrompts()) {
> +      todo(false, "Test disabled when tab modal prompts are not enabled.");

SimpleTest.finish()?

I think I'd prefer
if (hasTabModalPrompts()) {
} else {
}

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 607490 [details] [diff] [review]
(Av1) test_ui_modalprompt.html needs to check "prompts.tab_modal.enabled" preference
[Checked in: Comment 6]

(In reply to alexander :surkov from comment #3)

> SimpleTest.finish()?

No: skipping SimpleTest.waitForExplicitFinish() instead.

> I think I'd prefer
> if (hasTabModalPrompts()) {
> } else {
> }

"I/We" usually handle the "exception" first, but I can swap that code if you insist.

Comment 5

[alexander :surkov]

(In reply to Serge Gautherie (:sgautherie) from comment #4)
> Comment on attachment 607490 [details] [diff] [review]
> (Av1) test_ui_modalprompt.html needs to check "prompts.tab_modal.enabled"
> preference
> 
> (In reply to alexander :surkov from comment #3)
> 
> > SimpleTest.finish()?
> 
> No: skipping SimpleTest.waitForExplicitFinish() instead.

ok, I thought that SimpleTest.finish() is necessary part to finish a test.

> > I think I'd prefer
> > if (hasTabModalPrompts()) {
> > } else {
> > }
> 
> "I/We" usually handle the "exception" first, but I can swap that code if you
> insist.

ok, up to you

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 607490 [details] [diff] [review]
(Av1) test_ui_modalprompt.html needs to check "prompts.tab_modal.enabled" preference
[Checked in: Comment 6]

https://hg.mozilla.org/mozilla-central/rev/e97da8b4b939

Comment 7

[Serge Gautherie (:sgautherie)]

Ftr, it succeeded as
https://tbpl.mozilla.org/?tree=Try&rev=b5edde2abb07

Comment 8

[David Bolter [:davidb] (NeedInfo me for attention)]

Nice.

Comment 9

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1332324425.1332330787.5222.gz
Linux comm-central-trunk debug test mochitest-other on 2012/03/21 03:07:05

V.Fixed