Closed
Bug 736905
Opened 13 years ago
Closed 13 years ago
[SeaMonkey] "a11y/accessible/relations/test_ui_modalprompt.html | Test timed out."
Categories
(Core :: Disability Access APIs, defect, P2)
Core
Disability Access APIs
Tracking
()
VERIFIED
FIXED
mozilla14
People
(Reporter: sgautherie, Assigned: sgautherie)
References
(Depends on 1 open bug, Blocks 2 open bugs, )
Details
(Whiteboard: [perma-orange])
Attachments
(1 file)
1.72 KB,
patch
|
surkov
:
review+
surkov
:
feedback+
|
Details | Diff | Splinter Review |
I'm guessing this fails because SeaMonkey bug 625056 is not fixed yet, right?
Comment 1•13 years ago
|
||
(In reply to Serge Gautherie (:sgautherie) from comment #0)
> I'm guessing this fails because SeaMonkey bug 625056 is not fixed yet, right?
sounds right
Updated•13 years ago
|
Blocks: a11ytestdev
Assignee | ||
Comment 2•13 years ago
|
||
Copied+Adapted existing code to use SpecialPowers.
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #607490 -
Flags: review?(surkov.alexander)
Comment 3•13 years ago
|
||
Comment on attachment 607490 [details] [diff] [review]
(Av1) test_ui_modalprompt.html needs to check "prompts.tab_modal.enabled" preference
[Checked in: Comment 6]
Review of attachment 607490 [details] [diff] [review]:
-----------------------------------------------------------------
::: accessible/tests/mochitest/relations/test_ui_modalprompt.html
@@ +80,5 @@
> gQueue.invoke(); // will call SimpleTest.finish()
> }
>
> + if (!hasTabModalPrompts()) {
> + todo(false, "Test disabled when tab modal prompts are not enabled.");
SimpleTest.finish()?
I think I'd prefer
if (hasTabModalPrompts()) {
} else {
}
Attachment #607490 -
Flags: review?(surkov.alexander) → review+
Assignee | ||
Comment 4•13 years ago
|
||
Comment on attachment 607490 [details] [diff] [review]
(Av1) test_ui_modalprompt.html needs to check "prompts.tab_modal.enabled" preference
[Checked in: Comment 6]
(In reply to alexander :surkov from comment #3)
> SimpleTest.finish()?
No: skipping SimpleTest.waitForExplicitFinish() instead.
> I think I'd prefer
> if (hasTabModalPrompts()) {
> } else {
> }
"I/We" usually handle the "exception" first, but I can swap that code if you insist.
Attachment #607490 -
Flags: feedback?(surkov.alexander)
Comment 5•13 years ago
|
||
(In reply to Serge Gautherie (:sgautherie) from comment #4)
> Comment on attachment 607490 [details] [diff] [review]
> (Av1) test_ui_modalprompt.html needs to check "prompts.tab_modal.enabled"
> preference
>
> (In reply to alexander :surkov from comment #3)
>
> > SimpleTest.finish()?
>
> No: skipping SimpleTest.waitForExplicitFinish() instead.
ok, I thought that SimpleTest.finish() is necessary part to finish a test.
> > I think I'd prefer
> > if (hasTabModalPrompts()) {
> > } else {
> > }
>
> "I/We" usually handle the "exception" first, but I can swap that code if you
> insist.
ok, up to you
Updated•13 years ago
|
Attachment #607490 -
Flags: feedback?(surkov.alexander) → feedback+
Assignee | ||
Comment 6•13 years ago
|
||
Comment on attachment 607490 [details] [diff] [review]
(Av1) test_ui_modalprompt.html needs to check "prompts.tab_modal.enabled" preference
[Checked in: Comment 6]
https://hg.mozilla.org/mozilla-central/rev/e97da8b4b939
Attachment #607490 -
Attachment description: (Av1) test_ui_modalprompt.html needs to check "prompts.tab_modal.enabled" preference → (Av1) test_ui_modalprompt.html needs to check "prompts.tab_modal.enabled" preference
[Checked in: Comment 6]
Assignee | ||
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Hardware: x86 → All
Resolution: --- → FIXED
Assignee | ||
Comment 7•13 years ago
|
||
Ftr, it succeeded as
https://tbpl.mozilla.org/?tree=Try&rev=b5edde2abb07
Comment 8•13 years ago
|
||
Nice.
Assignee | ||
Comment 9•13 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1332324425.1332330787.5222.gz
Linux comm-central-trunk debug test mochitest-other on 2012/03/21 03:07:05
V.Fixed
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•