Wifi: Use DOMRequestHelper.jsm in DOMWifiManager.js

RESOLVED FIXED in mozilla14

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mrbkap, Assigned: mrbkap)

Tracking

(Blocks: 1 bug)

unspecified
mozilla14
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
DOMWifiManager.js and DOMRequestHelper.jsm were written in parallel. DOMWifiManager can lose a few lines by using the request helper.

One thing I noticed is that the request helper doesn't expose a takeRequest-like API (that is getAndRemoveRequest). Fabrice, would you have anything against adding such an API?
(In reply to Blake Kaplan (:mrbkap) from comment #0)

> One thing I noticed is that the request helper doesn't expose a
> takeRequest-like API (that is getAndRemoveRequest). Fabrice, would you have
> anything against adding such an API?

Of course not, go ahead!
(Assignee)

Comment 2

5 years ago
Created attachment 607574 [details] [diff] [review]
Patch
Assignee: nobody → mrbkap
Status: NEW → ASSIGNED
Attachment #607574 - Flags: review?(fabrice)
Attachment #607574 - Flags: review?(fabrice) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/mozilla-central/rev/ac271854f43d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.