Last Comment Bug 737029 - Wifi: Use DOMRequestHelper.jsm in DOMWifiManager.js
: Wifi: Use DOMRequestHelper.jsm in DOMWifiManager.js
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Device Interfaces (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: mozilla14
Assigned To: Blake Kaplan (:mrbkap)
:
:
Mentors:
Depends on:
Blocks: b2g-wifi
  Show dependency treegraph
 
Reported: 2012-03-19 07:51 PDT by Blake Kaplan (:mrbkap)
Modified: 2012-03-21 10:25 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (8.25 KB, patch)
2012-03-20 09:00 PDT, Blake Kaplan (:mrbkap)
fabrice: review+
Details | Diff | Splinter Review

Description Blake Kaplan (:mrbkap) 2012-03-19 07:51:45 PDT
DOMWifiManager.js and DOMRequestHelper.jsm were written in parallel. DOMWifiManager can lose a few lines by using the request helper.

One thing I noticed is that the request helper doesn't expose a takeRequest-like API (that is getAndRemoveRequest). Fabrice, would you have anything against adding such an API?
Comment 1 [:fabrice] Fabrice Desré 2012-03-19 07:55:59 PDT
(In reply to Blake Kaplan (:mrbkap) from comment #0)

> One thing I noticed is that the request helper doesn't expose a
> takeRequest-like API (that is getAndRemoveRequest). Fabrice, would you have
> anything against adding such an API?

Of course not, go ahead!
Comment 2 Blake Kaplan (:mrbkap) 2012-03-20 09:00:20 PDT
Created attachment 607574 [details] [diff] [review]
Patch
Comment 3 Blake Kaplan (:mrbkap) 2012-03-21 10:25:39 PDT
https://hg.mozilla.org/mozilla-central/rev/ac271854f43d

Note You need to log in before you can comment on or make changes to this bug.