Last Comment Bug 737122 - Attr nodes shouldn't have children
: Attr nodes shouldn't have children
Status: RESOLVED FIXED
: dev-doc-needed
Product: Core
Classification: Components
Component: DOM: Core & HTML (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla14
Assigned To: :Ms2ger
:
Mentors:
Depends on: 766373 779838 780882
Blocks: AttrExodus
  Show dependency treegraph
 
Reported: 2012-03-19 12:15 PDT by :Ms2ger
Modified: 2014-10-28 07:52 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (38.29 KB, patch)
2012-03-19 12:15 PDT, :Ms2ger
no flags Details | Diff | Review
Patch v1.1 (38.26 KB, patch)
2012-03-22 13:20 PDT, :Ms2ger
jonas: review+
Details | Diff | Review

Description :Ms2ger 2012-03-19 12:15:52 PDT
Created attachment 607249 [details] [diff] [review]
Patch v1

content/base/public/Makefile.in                   |    1 -
 content/base/public/nsIMutationObserver2.h        |   93 ------------------------------------------------------------
 content/base/src/nsDOMAttribute.cpp               |  170 ++++++++++---------------------------------------------------------------------------------------------------
 content/base/src/nsDOMAttribute.h                 |   23 ++------------
 content/base/src/nsNodeIterator.cpp               |    9 -----
 content/base/src/nsNodeIterator.h                 |    3 +-
 content/base/src/nsNodeUtils.cpp                  |   55 +----------------------------------
 content/base/src/nsNodeUtils.h                    |    7 ----
 content/base/src/nsStubMutationObserver.cpp       |    3 -
 content/base/src/nsStubMutationObserver.h         |    5 ---
 content/base/src/nsTextNode.cpp                   |   23 --------------
 content/base/src/nsTextNode.h                     |    7 ----
 content/base/test/Makefile.in                     |    5 ---
 content/base/test/test_bug590771.html             |   72 ----------------------------------------------
 content/base/test/test_bug598877.html             |   26 ----------------
 content/base/test/test_bug600466.html             |   28 ------------------
 content/base/test/test_bug600468.html             |   28 ------------------
 content/base/test/test_bug600471.html             |   29 ------------------
 dom/tests/mochitest/dom-level1-core/exclusions.js |    6 +++-
 19 files changed, 28 insertions(+), 565 deletions(-)
Comment 1 :Ms2ger 2012-03-22 13:20:13 PDT
Created attachment 608443 [details] [diff] [review]
Patch v1.1

RemoveChildAt shouldn't throw
Comment 2 Jonas Sicking (:sicking) PTO Until July 5th 2012-04-01 22:44:32 PDT
Comment on attachment 608443 [details] [diff] [review]
Patch v1.1

Review of attachment 608443 [details] [diff] [review]:
-----------------------------------------------------------------

yay!
Comment 4 Mike Taylor [:miketaylr] 2014-10-28 07:52:24 PDT
It seems this change broke OSX Mavericks Server web calendar: See Bug 939619

Note You need to log in before you can comment on or make changes to this bug.