Closed Bug 737122 Opened 11 years ago Closed 11 years ago

Attr nodes shouldn't have children

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla14

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file, 1 obsolete file)

Patch v1.1
38.26 KB, patch
sicking
: review+
Details | Diff | Splinter Review
Attached patch Patch v1 (obsolete) — — Splinter Review 
content/base/public/Makefile.in                   |    1 -
 content/base/public/nsIMutationObserver2.h        |   93 ------------------------------------------------------------
 content/base/src/nsDOMAttribute.cpp               |  170 ++++++++++---------------------------------------------------------------------------------------------------
 content/base/src/nsDOMAttribute.h                 |   23 ++------------
 content/base/src/nsNodeIterator.cpp               |    9 -----
 content/base/src/nsNodeIterator.h                 |    3 +-
 content/base/src/nsNodeUtils.cpp                  |   55 +----------------------------------
 content/base/src/nsNodeUtils.h                    |    7 ----
 content/base/src/nsStubMutationObserver.cpp       |    3 -
 content/base/src/nsStubMutationObserver.h         |    5 ---
 content/base/src/nsTextNode.cpp                   |   23 --------------
 content/base/src/nsTextNode.h                     |    7 ----
 content/base/test/Makefile.in                     |    5 ---
 content/base/test/test_bug590771.html             |   72 ----------------------------------------------
 content/base/test/test_bug598877.html             |   26 ----------------
 content/base/test/test_bug600466.html             |   28 ------------------
 content/base/test/test_bug600468.html             |   28 ------------------
 content/base/test/test_bug600471.html             |   29 ------------------
 dom/tests/mochitest/dom-level1-core/exclusions.js |    6 +++-
 19 files changed, 28 insertions(+), 565 deletions(-)
Attachment #607249 - Flags: review?(jonas)
Attached patch Patch v1.1 — — Splinter Review 
RemoveChildAt shouldn't throw
Attachment #607249 - Attachment is obsolete: true
Attachment #607249 - Flags: review?(jonas)
Attachment #608443 - Flags: review?(jonas)
Comment on attachment 608443 [details] [diff] [review]
Patch v1.1

Review of attachment 608443 [details] [diff] [review]:
-----------------------------------------------------------------

yay!
Attachment #608443 - Flags: review?(jonas) → review+
https://hg.mozilla.org/mozilla-central/rev/af7362ead6e5
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
Depends on: 766373
Depends on: 779838
Depends on: 780882
It seems this change broke OSX Mavericks Server web calendar: See Bug 939619
See Also: → 939619
I've finally marked the related attributes and methods as obsolete at https://developer.mozilla.org/en-US/docs/Web/API/Attr#Deprecated_properties_and_methods.

Please let me know whether I missed anything!

Sebastian
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.