Last Comment Bug 737167 - Build changes to support gonk-ics
: Build changes to support gonk-ics
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: unspecified
: All Gonk (Firefox OS)
: -- normal (vote)
: ---
Assigned To: Michael Wu [:mwu]
:
: Gregory Szorc [:gps]
Mentors:
Depends on:
Blocks: gonk-ics
  Show dependency treegraph
 
Reported: 2012-03-19 13:34 PDT by Michael Wu [:mwu]
Modified: 2012-03-25 10:49 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
1/2: Allow the toolchain to be specified via mozconfig (3.34 KB, patch)
2012-03-19 13:36 PDT, Michael Wu [:mwu]
cjones.bugs: review+
Details | Diff | Splinter Review
2/2: Autodetect ICS (1.25 KB, patch)
2012-03-19 13:38 PDT, Michael Wu [:mwu]
cjones.bugs: review-
Details | Diff | Splinter Review

Description Michael Wu [:mwu] 2012-03-19 13:34:12 PDT

    
Comment 1 Michael Wu [:mwu] 2012-03-19 13:36:52 PDT
Created attachment 607288 [details] [diff] [review]
1/2: Allow the toolchain to be specified via mozconfig

I seem to get build issues in JS without switching to a newer toolchain. This patch lets us easily switch between toolchains.
Comment 2 Michael Wu [:mwu] 2012-03-19 13:38:07 PDT
Created attachment 607289 [details] [diff] [review]
2/2: Autodetect ICS

This patch sets MOZ_B2G_ICS when we're building against an ICS tree.
Comment 3 Andreas Gal :gal 2012-03-19 13:49:58 PDT
We decided to do runtime detection instead so we can auto update one gecko.
Comment 4 Michael Wu [:mwu] 2012-03-19 13:56:42 PDT
(In reply to Andreas Gal :gal from comment #3)
> We decided to do runtime detection instead so we can auto update one gecko.

Runtime detection doesn't help when the headers move. Most of these ifdefs are used just to make things compile, but if done right, shouldn't affect our ability to ship a single binary on both GB and ICS.
Comment 5 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-03-20 10:41:52 PDT
Comment on attachment 607289 [details] [diff] [review]
2/2: Autodetect ICS

I don't want a compile-time GB/ICS switch unless it's absolutely necessary.

Convince me that this is absolutely necessary.
Comment 6 Andreas Gal :gal 2012-03-24 18:14:07 PDT
http://hg.mozilla.org/mozilla-central/rev/33fa8d55914c

Note You need to log in before you can comment on or make changes to this bug.