737167 - Build changes to support gonk-ics

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Michael Wu [:mwu]]

Attachment: 1/2: Allow the toolchain to be specified via mozconfig

I seem to get build issues in JS without switching to a newer toolchain. This patch lets us easily switch between toolchains.

Comment 2

[Michael Wu [:mwu]]

Attachment: 2/2: Autodetect ICS

This patch sets MOZ_B2G_ICS when we're building against an ICS tree.

Comment 3

[Andreas Gal :gal]

We decided to do runtime detection instead so we can auto update one gecko.

Comment 4

[Michael Wu [:mwu]]

(In reply to Andreas Gal :gal from comment #3)
> We decided to do runtime detection instead so we can auto update one gecko.

Runtime detection doesn't help when the headers move. Most of these ifdefs are used just to make things compile, but if done right, shouldn't affect our ability to ship a single binary on both GB and ICS.

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 607289 [details] [diff] [review]
2/2: Autodetect ICS

I don't want a compile-time GB/ICS switch unless it's absolutely necessary.

Convince me that this is absolutely necessary.

Comment 6

[Andreas Gal :gal]

http://hg.mozilla.org/mozilla-central/rev/33fa8d55914c