Closed Bug 737167 Opened 8 years ago Closed 8 years ago

Build changes to support gonk-ics

Categories

(Firefox Build System :: General, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mwu, Assigned: mwu)

References

Details

Attachments

(2 files)

No description provided.
I seem to get build issues in JS without switching to a newer toolchain. This patch lets us easily switch between toolchains.
Attachment #607288 - Flags: review?
This patch sets MOZ_B2G_ICS when we're building against an ICS tree.
Attachment #607289 - Flags: review?(jones.chris.g)
Attachment #607289 - Flags: review?(gal)
Attachment #607288 - Flags: review?(jones.chris.g)
Attachment #607288 - Flags: review?(gal)
Attachment #607288 - Flags: review?
We decided to do runtime detection instead so we can auto update one gecko.
(In reply to Andreas Gal :gal from comment #3)
> We decided to do runtime detection instead so we can auto update one gecko.

Runtime detection doesn't help when the headers move. Most of these ifdefs are used just to make things compile, but if done right, shouldn't affect our ability to ship a single binary on both GB and ICS.
Attachment #607288 - Flags: review?(jones.chris.g) → review+
Comment on attachment 607289 [details] [diff] [review]
2/2: Autodetect ICS

I don't want a compile-time GB/ICS switch unless it's absolutely necessary.

Convince me that this is absolutely necessary.
Attachment #607289 - Flags: review?(jones.chris.g) → review-
http://hg.mozilla.org/mozilla-central/rev/33fa8d55914c
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Attachment #607288 - Flags: review?(gal)
Attachment #607289 - Flags: review?(gal)
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.