Last Comment Bug 737173 - Fix AudioManager and sydney_audio_gonk on ICS
: Fix AudioManager and sydney_audio_gonk on ICS
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Device Interfaces (show other bugs)
: unspecified
: All Gonk (Firefox OS)
: -- normal (vote)
: ---
Assigned To: Michael Wu [:mwu]
:
:
Mentors:
: 736933 (view as bug list)
Depends on:
Blocks: gonk-ics 739090
  Show dependency treegraph
 
Reported: 2012-03-19 13:39 PDT by Michael Wu [:mwu]
Modified: 2012-03-29 14:33 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Fix audio (2.32 KB, patch)
2012-03-19 13:39 PDT, Michael Wu [:mwu]
cjones.bugs: review-
Details | Diff | Splinter Review
part 1: Import the Gingerbread/Ice Cream Sandwich-compatible audio client code (99.46 KB, patch)
2012-03-25 02:06 PDT, Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
cjones.bugs: review+
Details | Diff | Splinter Review
part 2: Port AudioManager and libsydneyaudio to the new import (3.66 KB, patch)
2012-03-25 02:08 PDT, Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
cjones.bugs: review+
Details | Diff | Splinter Review

Description Michael Wu [:mwu] 2012-03-19 13:39:51 PDT
Created attachment 607290 [details] [diff] [review]
Fix audio

This is a patch from an anonymous silicon vendor contributor. It works for me.
Comment 1 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-03-20 10:45:05 PDT
Comment on attachment 607290 [details] [diff] [review]
Fix audio

Hi, we had discussed using a compat header to avoid having to do these ifdef's in gecko.
Comment 2 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-03-25 02:06:26 PDT
Created attachment 609091 [details] [diff] [review]
part 1: Import the Gingerbread/Ice Cream Sandwich-compatible audio client code
Comment 3 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-03-25 02:08:38 PDT
Created attachment 609092 [details] [diff] [review]
part 2: Port AudioManager and libsydneyaudio to the new import

I'm not enthused about this port but it's going away soon, so OK.  Issues
 - we "just happen" to be GB and ICS compatible.  There's no reason why this should be the case.  It's nice that things worked out this way, but the real fix is to directly talk to the audio HAL.  That work is underway.
 - need to file a followup for the setForce/getForce issue.  I don't fully understand what's going wrong in the ICS codebase there.

mwu, please file a followup bug with the reasons why that code is commented out.
Comment 4 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-03-25 02:12:21 PDT
https://hg.mozilla.org/mozilla-central/rev/2fae50aeacf1
https://hg.mozilla.org/mozilla-central/rev/7e51d72827a6

Please file followup.
Comment 5 Michael Wu [:mwu] 2012-03-29 14:33:30 PDT
*** Bug 736933 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.