737173 - Fix AudioManager and sydney_audio_gonk on ICS

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Michael Wu [:mwu]]

Attachment: Fix audio

This is a patch from an anonymous silicon vendor contributor. It works for me.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 607290 [details] [diff] [review]
Fix audio

Hi, we had discussed using a compat header to avoid having to do these ifdef's in gecko.

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: part 1: Import the Gingerbread/Ice Cream Sandwich-compatible audio client code

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: part 2: Port AudioManager and libsydneyaudio to the new import

I'm not enthused about this port but it's going away soon, so OK.  Issues
 - we "just happen" to be GB and ICS compatible.  There's no reason why this should be the case.  It's nice that things worked out this way, but the real fix is to directly talk to the audio HAL.  That work is underway.
 - need to file a followup for the setForce/getForce issue.  I don't fully understand what's going wrong in the ICS codebase there.

mwu, please file a followup bug with the reasons why that code is commented out.

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

https://hg.mozilla.org/mozilla-central/rev/2fae50aeacf1
https://hg.mozilla.org/mozilla-central/rev/7e51d72827a6

Please file followup.