Closed
Bug 737173
Opened 13 years ago
Closed 13 years ago
Fix AudioManager and sydney_audio_gonk on ICS
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mwu, Assigned: mwu)
References
Details
Attachments
(2 files, 1 obsolete file)
99.46 KB,
patch
|
cjones
:
review+
|
Details | Diff | Splinter Review |
3.66 KB,
patch
|
cjones
:
review+
|
Details | Diff | Splinter Review |
This is a patch from an anonymous silicon vendor contributor. It works for me.
Attachment #607290 -
Flags: review?(jones.chris.g)
Attachment #607290 -
Flags: review?(gal)
Assignee | ||
Updated•13 years ago
|
Attachment #607290 -
Attachment description: Anonymous Silicon Vendor contributor → Fix audio
Comment on attachment 607290 [details] [diff] [review] Fix audio Hi, we had discussed using a compat header to avoid having to do these ifdef's in gecko.
Attachment #607290 -
Flags: review?(jones.chris.g) → review-
Attachment #607290 -
Attachment is obsolete: true
Attachment #607290 -
Flags: review?(gal)
Attachment #609091 -
Flags: review+
I'm not enthused about this port but it's going away soon, so OK. Issues - we "just happen" to be GB and ICS compatible. There's no reason why this should be the case. It's nice that things worked out this way, but the real fix is to directly talk to the audio HAL. That work is underway. - need to file a followup for the setForce/getForce issue. I don't fully understand what's going wrong in the ICS codebase there. mwu, please file a followup bug with the reasons why that code is commented out.
Attachment #609092 -
Flags: review+
https://hg.mozilla.org/mozilla-central/rev/2fae50aeacf1 https://hg.mozilla.org/mozilla-central/rev/7e51d72827a6 Please file followup.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•