Last Comment Bug 737196 - Make camera code build on gonk-ics
: Make camera code build on gonk-ics
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Device Interfaces (show other bugs)
: unspecified
: All Gonk (Firefox OS)
: -- normal (vote)
: mozilla14
Assigned To: Michael Wu [:mwu]
:
: Andrew Overholt [:overholt]
Mentors:
Depends on:
Blocks: gonk-ics
  Show dependency treegraph
 
Reported: 2012-03-19 14:20 PDT by Michael Wu [:mwu]
Modified: 2012-03-25 00:10 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Make camera code build on gonk-ics (3.15 KB, patch)
2012-03-19 14:20 PDT, Michael Wu [:mwu]
cjones.bugs: review-
Details | Diff | Splinter Review
Make camera code build on gonk-ics, v2 (41.23 KB, patch)
2012-03-24 22:06 PDT, Michael Wu [:mwu]
cjones.bugs: review+
Details | Diff | Splinter Review

Description Michael Wu [:mwu] 2012-03-19 14:20:36 PDT
Created attachment 607320 [details] [diff] [review]
Make camera code build on gonk-ics

This patch just stops the bleeding and lets us build. It's another patch from an anonymous silicon vendor contributor. It looks like some significant changes will be required to support the new ICS camera api.
Comment 1 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-03-20 10:47:11 PDT
Comment on attachment 607320 [details] [diff] [review]
Make camera code build on gonk-ics

Same comment here about compat header.  We can add the new path to the include search list unconditionally, I believe.  (mvines's patch was a hack and slash, as he said.)
Comment 2 Michael Wu [:mwu] 2012-03-24 22:06:15 PDT
Created attachment 609073 [details] [diff] [review]
Make camera code build on gonk-ics, v2

Imported gb headers
Comment 3 Michael Wu [:mwu] 2012-03-25 00:10:59 PDT
https://hg.mozilla.org/mozilla-central/rev/1a99df27f7b9

Note You need to log in before you can comment on or make changes to this bug.