The default bug view has changed. See this FAQ.

Wifi: Shut down the wifi workers cleanly

RESOLVED FIXED in mozilla14

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mrbkap, Assigned: mrbkap)

Tracking

(Blocks: 1 bug)

unspecified
mozilla14
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
cjones found me on IRC today and mentioned that currently B2G doesn't shut down cleanly because during shutdown, workers try to join all of the threads, but wifi has a thread stuck waiting for messages from wpa_supplicant.
(Assignee)

Comment 1

5 years ago
Created attachment 607531 [details] [diff] [review]
Possible fix

Chris, I haven't been able to reproduce the shutdown hang, but this *should* fix it. Can you let me know if this helps?
Assignee: nobody → mrbkap
Status: NEW → ASSIGNED
Attachment #607531 - Flags: review?(jones.chris.g)
Comment on attachment 607531 [details] [diff] [review]
Possible fix

I'll give this a shot, but not confident it'll solve the problem in general.
Blocks: 737368
(Assignee)

Comment 3

5 years ago
Oh, I should have mentioned. The shutdown method added to nsIWifi and called here (but seemingly not added in the patch) already existed in WifiWorker.js and it calls WifiManager.setEnabled(false). This has the effect of telling the wpa_supplicant to shut down, unblocking the shutdown process.
Comment on attachment 607531 [details] [diff] [review]
Possible fix

WFM!
Attachment #607531 - Flags: review?(jones.chris.g) → review+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/6e9a8454ccae
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.