737417 - Split charset source constants out of nsIParser.h

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[Henri Sivonen (:hsivonen) (away from Bugzilla until 2026-04-13)]

There should be parser/nsCharsetSource.h for the kCharset* constants that are now in nsIParser.h to make fewer places include nsIParser.h.

Note that in order to avoid burning comm-central, the first patch should make nsIParser.h include the new nsCharsetSource.h. Then comm-central can move to including nsCharsetSource.h directly and then nsIParser.h can stop including nsCharsetSource.h.

Comment 1

[Henri Sivonen (:hsivonen) (away from Bugzilla until 2026-04-13)]

Taking this myself in order to get a better idea of the remaining real nsIParser deps.

Comment 2

[Henri Sivonen (:hsivonen) (away from Bugzilla until 2026-04-13)]

Attachment: Part 1: Split the constants out and remove useless nsIParser.h includes

Comment 3

[Henri Sivonen (:hsivonen) (away from Bugzilla until 2026-04-13)]

Attachment: Part 3: Remove comm-central scaffolding

Part 2 will be a comm-central patch.

Comment 4

[Henri Sivonen (:hsivonen) (away from Bugzilla until 2026-04-13)]

Attachment: Part 1: Split the constants out and remove useless nsIParser.h includes, without accidental file removal

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 607959 [details] [diff] [review]
Part 1: Split the constants out and remove useless nsIParser.h includes, without accidental file removal

Review of attachment 607959 [details] [diff] [review]:
-----------------------------------------------------------------

::: parser/Makefile.in
@@ +46,5 @@
>  DIRS            = expat xml htmlparser html
>  
> +EXPORTS		= \
> +		nsCharsetSource.h \
> +		$(NULL)

Just

EXPORTS = \
  nsCharsetSource.h \
  $(NULL)

please, no tabs

Comment 6

[Henri Sivonen (:hsivonen) (away from Bugzilla until 2026-04-13)]

Attachment: Part 1: Split the constants out and remove useless nsIParser.h includes, for real the right patch

Comment 7

[Henri Sivonen (:hsivonen) (away from Bugzilla until 2026-04-13)]

Attachment: Part 2: Remove nsIParser.h from comm-central

Comment 8

[Henri Sivonen (:hsivonen) (away from Bugzilla until 2026-04-13)]

Attachment: Part 1: Split the constants out and remove useless nsIParser.h includes, Ms2ger's comments addressed

Comment 9

[Henri Sivonen (:hsivonen) (away from Bugzilla until 2026-04-13)]

Attachment: Part 2: Remove nsIParser.h from comm-central

Comment 10

[Henri Sivonen (:hsivonen) (away from Bugzilla until 2026-04-13)]

Attachment: Part 2: Remove nsIParser.h and nsIHTMLContentSink.h from comm-central

Let's remove the nsIHTMLContentSink.h #include while at it.

Comment 11

[Henri Sivonen (:hsivonen) (away from Bugzilla until 2026-04-13)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/323deae312d2

Comment 12

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/323deae312d2

Comment 13

[Mark Banner (:standard8)]

Comment on attachment 608303 [details] [diff] [review]
Part 2: Remove nsIParser.h and nsIHTMLContentSink.h from comm-central

I've not tested it, but this looks fine.

Comment 14

[Henri Sivonen (:hsivonen) (away from Bugzilla until 2026-04-13)]

Thanks for the reviews.

Landed parts 2 and 3:
http://hg.mozilla.org/comm-central/rev/d5bc8c4eeb2f
http://hg.mozilla.org/integration/mozilla-inbound/rev/c2a5e0dba377

Comment 15

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c2a5e0dba377