Closed Bug 737457 Opened 13 years ago Closed 13 years ago

Intermittent browser/devtools/tilt/test/browser_tilt_picking_highlight02.js | Test timed out | Found a tab after previous test timed out

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Version:
14 Branch
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox13 fixed, firefox14 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 14
Tracking Flags:
Tracking Status
firefox13 --- fixed
firefox14 --- fixed

People

(Reporter: mbrubeck, Assigned: vporof)

References

Details

(Keywords: intermittent-failure)

Attachments

(2 files, 1 obsolete file)

screenshot
206.93 KB, image/png
Details
[land me] v2
5.46 KB, patch
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Attached image screenshot —
https://tbpl.mozilla.org/php/getParsedLog.php?id=10210450&tree=Mozilla-Inbound Rev3 WINNT 6.1 mozilla-inbound opt test mochitest-other on 2012-03-20 05:02:40 PDT for push 60dd3e5fe989 INFO TEST-END | chrome://mochitests/content/browser/browser/devtools/tilt/test/browser_tilt_picking_highlight01.js | finished in 584ms TEST-INFO | checking window state TEST-START | chrome://mochitests/content/browser/browser/devtools/tilt/test/browser_tilt_picking_highlight02.js TEST-PASS | chrome://mochitests/content/browser/browser/devtools/tilt/test/browser_tilt_picking_highlight02.js | Highlighting a node didn't work properly. TEST-PASS | chrome://mochitests/content/browser/browser/devtools/tilt/test/browser_tilt_picking_highlight02.js | After highlighting a node, it should be highlighted. D'oh. TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/tilt/test/browser_tilt_picking_highlight02.js | Test timed out INFO TEST-END | chrome://mochitests/content/browser/browser/devtools/tilt/test/browser_tilt_picking_highlight02.js | finished in 30036ms TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/tilt/test/browser_tilt_picking_highlight02.js | Found a tab after previous test timed out: data:text/html,<DOCTYPE%20html><html><head><title>Three%20Laws</title></head><body><div%20id='first-law'>A%20robot%20may%20not%20injure%20a%20human%20being%20or,%20through%20inaction,%20allow%20a%20human%20being%20to%20come%20to%20harm.</div><div>A%20robot%20must%20obey%20the%20orders%20given%20to%20it%20by%20human%20beings,%20except%20where%20such%20orders%20would%20conflict%20with%20the%20First%20Law.</div><div>A%20robot%20must%20protect%20its%20own%20existence%20as%20long%20as%20such%20protection%20does%20not%20conflict%20with%20the%20First%20or%20Second%20Laws.</div><div%20id='far-far-away'%20style='position:%20absolute;%20top:%20250%;'>I%20like%20bacon.</div><body></html> TEST-INFO | checking window state TEST-START | chrome://mochitests/content/browser/browser/devtools/tilt/test/browser_tilt_picking_highlight03.js TEST-PASS | chrome://mochitests/content/browser/browser/devtools/tilt/test/browser_tilt_picking_highlight03.js | Highlighting a node didn't work properly. TEST-PASS | chrome://mochitests/content/browser/browser/devtools/tilt/test/browser_tilt_picking_highlight03.js | After highlighting a node, it should be highlighted. D'oh. TEST-PASS | chrome://mochitests/content/browser/browser/devtools/tilt/test/browser_tilt_picking_highlight03.js | Unhighlighting a should remove the current selection. TEST-PASS | chrome://mochitests/content/browser/browser/devtools/tilt/test/browser_tilt_picking_highlight03.js | After unhighlighting a node, it shouldn't be highlighted anymore. D'oh. INFO TEST-END | chrome://mochitests/content/browser/browser/devtools/tilt/test/browser_tilt_picking_highlight03.js | finished in 600ms
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attached patch v1 (obsolete) — — Splinter Review
Attachment #609671 - Flags: review?(rcampbell)
Comment on attachment 609671 [details] [diff] [review] v1 ok, but would prefer a version that gets rid of those requestLongerTimeouts.
Attachment #609671 - Flags: review?(rcampbell) → review+
(In reply to Rob Campbell [:rc] (:robcee) from comment #46) > Comment on attachment 609671 [details] [diff] [review] > v1 > > ok, but would prefer a version that gets rid of those requestLongerTimeouts. Pushed to try a version without them. Let's see what happens.
Attached patch [land me] v2 — — Splinter Review
(In reply to Victor Porof from comment #47) > (In reply to Rob Campbell [:rc] (:robcee) from comment #46) > > Comment on attachment 609671 [details] [diff] [review] > > v1 > > > > ok, but would prefer a version that gets rid of those requestLongerTimeouts. > > Pushed to try a version without them. Let's see what happens. It worked without any requestLongerTimeout \o/
Attachment #609671 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/014c39d29e30
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [orange][fixed-in-fx-team] → [orange]
Target Milestone: --- → Firefox 14
Comment on attachment 610065 [details] [diff] [review] [land me] v2 [Approval Request Comment] Regression caused by (bug #): new code User impact if declined: none Testing completed (on m-c, etc.): been on m-c for 2 weeks. Test failures stopped. Risk to taking this patch (and alternatives if risky): none, testfix only String changes made by this patch: none
Attachment #610065 - Flags: approval-mozilla-aurora?
Attachment #610065 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Whiteboard: [orange]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: