Closed
Bug 737535
Opened 12 years ago
Closed 12 years ago
10.0.3esr opens "whatsnew" page after update.
Categories
(Firefox :: Settings UI, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: stransky, Assigned: stransky)
References
()
Details
(Whiteboard: [qa+:ashughes])
Attachments
(1 file)
|
865 bytes,
patch
|
Gavin
:
review+
lsblakk
:
approval-mozilla-esr10+
nthomas
:
checkin+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #736001 +++ As far as the 10.0 ESR line stays the same (only security fixes are taken), there's no point to show the "whatsnew" page after update.
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → stransky
|
||
Updated•12 years ago
|
tracking-firefox-esr10:
--- → ?
|
|
Assignee | |
Comment 1•12 years ago
|
||
If the startup.homepage_override_url is empty the page is not shown after update.
|
|
Assignee | |
Updated•12 years ago
|
Attachment #609659 -
Flags: review?(akeybl)
|
||
Updated•12 years ago
|
Attachment #609659 -
Flags: review?(akeybl) → review?(gavin.sharp)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 609659 [details] [diff] [review] patch (ESR only) r=me (only for landing on the ESR branch, of course)
Attachment #609659 -
Flags: review?(gavin.sharp) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Comment on attachment 609659 [details] [diff] [review] patch (ESR only) It's for 10ESR only.
Attachment #609659 -
Flags: checkin?
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 4•12 years ago
|
||
Needs approval‑mozilla‑esr10+ first, please request it on the patch.
Keywords: checkin-needed
|
|
Assignee | |
Updated•12 years ago
|
Attachment #609659 -
Flags: approval-mozilla-esr10?
|
||
Updated•12 years ago
|
Attachment #609659 -
Flags: approval-mozilla-esr10? → approval-mozilla-esr10+
|
|
||
Updated•12 years ago
|
Keywords: checkin-needed
|
|
||
Updated•12 years ago
|
Attachment #609659 -
Attachment description: patch → patch (ESR only)
|
|
||
Updated•12 years ago
|
Whiteboard: [needs checking in on esr-10]
|
|
||
Comment 5•12 years ago
|
||
Comment on attachment 609659 [details] [diff] [review] patch (ESR only) http://hg.mozilla.org/releases/mozilla-esr10/rev/8fba363e0513
Attachment #609659 -
Flags: checkin? → checkin+
|
|
||
Updated•12 years ago
|
Keywords: checkin-needed
Whiteboard: [needs checking in on esr-10]
|
|
||
Updated•12 years ago
|
|
|
||
Updated•12 years ago
|
status-firefox-esr10:
--- → fixed
|
|
||
Comment 6•12 years ago
|
||
All done here ?
|
|
||
Comment 7•12 years ago
|
||
Yep, looks like it.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Comment 8•12 years ago
|
||
(In reply to Martin Stránský from comment #1) > Created attachment 609659 [details] [diff] [review] > patch (ESR only) > > If the startup.homepage_override_url is empty the page is not shown after > update. After updating FF 10.0.3 ESR build 1 to FF 10.0.4 ESR (FF 10.0.3 ESR build 2 doesn't update), "whatsnew" page is not displayed but startup.homepage_override_url is NOT empty. Is this correct? Tested on Win 7/64, Ubuntu 11.10/64, Mac OS X 10.6.8
|
|
Assignee | |
Comment 9•12 years ago
|
||
The change has been made for branded firefox only, maybe because of that?
|
||
Comment 10•12 years ago
|
||
(In reply to Martin Stránský from comment #9) > The change has been made for branded firefox only, maybe because of that? So I guess this is not something we can verify until we have official candidate builds for 10.0.4ESR?
|
|
||
Comment 11•12 years ago
|
||
Do the builds you're testing use official branding, or not?
|
|
||
Comment 12•12 years ago
|
||
No, the ESR 10.0.4pre builds are Nightly branded.
|
|
||
Comment 13•12 years ago
|
||
Verified fixed with 10.0.3esr -> 10.0.4esr updates on esr channel.
Whiteboard: [qa+] → [qa+:ashughes]
You need to log in
before you can comment on or make changes to this bug.
Description
•