Closed
Bug 737575
Opened 13 years ago
Closed 13 years ago
Text doesn't appear on matrix.itasoftware.com
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: Margaret, Assigned: luke)
References
()
Details
(Keywords: regression, Whiteboard: [qa+])
Attachments
(2 files)
197.42 KB,
image/png
|
Details | |
1.78 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
I haven't looked into this closely to see what styles they're using, but a lot of the text around the form fields on matrix.itasoftware.com is not visible. Screenshot attached.
It works in the latest Aurora, but busted in Nightly.
![]() |
||
Comment 1•13 years ago
|
||
Regression window(m-c),
Works:
http://hg.mozilla.org/mozilla-central/rev/ee56787a20fb
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:14.0) Gecko/20120316 Firefox/14.0a1 ID:20120316025529
Fails:
http://hg.mozilla.org/mozilla-central/rev/7f540f758671
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:14.0) Gecko/20120316 Firefox/14.0a1 ID:20120316054431
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ee56787a20fb&tochange=7f540f758671
Regression window(m-i),
Works:
http://hg.mozilla.org/integration/mozilla-inbound/rev/b752b0c0dc02
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:14.0) Gecko/20120315 Firefox/14.0a1 ID:20120315100728
Fails:
http://hg.mozilla.org/integration/mozilla-inbound/rev/8f3b804118ef
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:14.0) Gecko/20120315 Firefox/14.0a1 ID:20120315102728
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=b752b0c0dc02&tochange=8f3b804118ef
Triggered by: Bug 730497
![]() |
||
Comment 2•13 years ago
|
||
It's not styles. The text is not present in the DOM either.
All that stuff seems to be script-generated, and they're running into some sort of scripting issue. E.g. see the "undefined" next to the dropdown with 1--9 in it...
![]() |
||
Updated•13 years ago
|
Assignee: nobody → general
Blocks: 730497
tracking-firefox14:
--- → ?
Component: General → JavaScript Engine
Keywords: qawanted,
regressionwindow-wanted
OS: Mac OS X → All
QA Contact: general → general
Hardware: x86 → All
![]() |
Assignee | |
Comment 3•13 years ago
|
||
Attachment #607779 -
Flags: review?(dvander)
![]() |
Assignee | |
Comment 4•13 years ago
|
||
The bug was that arguments["i"] needs to return arguments[i] (for integers i) and the patch failed to do that when the arguments object had been optimized away (NormalArgumentsObject::optimizedGetElem).
Thanks for reporting Margaret!
![]() |
||
Updated•13 years ago
|
Attachment #607779 -
Flags: review?(dvander) → review+
Reporter | ||
Comment 5•13 years ago
|
||
(In reply to Luke Wagner [:luke] from comment #4)
> Thanks for reporting Margaret!
Thanks for the super quick fix!
![]() |
Assignee | |
Comment 6•13 years ago
|
||
![]() |
Assignee | |
Updated•13 years ago
|
Target Milestone: --- → mozilla14
Comment 7•13 years ago
|
||
Updated•13 years ago
|
Comment 10•13 years ago
|
||
Verified that text is properly displayed on:
http://matrix.itasoftware.com/
http://gs.statcounter.com/
Verified using Firefox 14 beta 8 on Windows XP, Mac OS X 10.6 and on Ubuntu 12.04:
Mozilla/5.0 (Windows NT 6.1; rv:14.0) Gecko/20100101 Firefox/14.0
Mozilla/5.0 (X11; Linux i686; rv:14.0) Gecko/20100101 Firefox/14.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:14.0) Gecko/20100101 Firefox/14.0
Whiteboard: [qa+]
You need to log in
before you can comment on or make changes to this bug.
Description
•