Closed
Bug 737661
Opened 13 years ago
Closed 12 years ago
Stop running tests on the Jetpack tree on Win64
Categories
(Release Engineering :: General, defect, P2)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: philor, Assigned: emorley)
References
Details
(Whiteboard: [jetpack][capacity][simple][win64])
Attachments
(1 file, 1 obsolete file)
1.13 KB,
patch
|
catlee
:
review+
emorley
:
checked-in+
|
Details | Diff | Splinter Review |
Every time a push to the Jetpack repo triggers tests on the Jetpack tree, we assign four Win64 slaves the job of downloading a Win64 debug build from each of mozilla-central, mozilla-aurora, mozilla-beta and mozilla-release to test against.
Oops, we don't build Win64 debug.
We also assign four Win64 slaves the job of downloading a Win64 opt build from each tree.
Oops, we only build Win64 opt on mozilla-central, so three of the four spend a minute plus startup time plus reboot time just to find that out again, every single push to the jetpack repo.
Updated•13 years ago
|
Priority: -- → P2
Whiteboard: [jetpack][capacity] → [jetpack][capacity][simple]
Updated•13 years ago
|
Whiteboard: [jetpack][capacity][simple] → [jetpack][capacity][simple][win64]
To preface this, I'm not a Python person.
So I have no idea if this is the correct style, does the right thing, or if it even compiles.
That said, it'd be nice to get this fixed, and I think this would be one way to do it.
Attachment #627447 -
Flags: review?(catlee)
Comment 2•13 years ago
|
||
Comment on attachment 627447 [details] [diff] [review]
v1
Review of attachment 627447 [details] [diff] [review]:
-----------------------------------------------------------------
I think the right place to be making this adjustment is in
http://hg.mozilla.org/build/buildbot-configs/file/c8feab772b4b/mozilla-tests/config.py#l970
Attachment #627447 -
Flags: review?(catlee) → review-
(In reply to Chris AtLee [:catlee] from comment #2)
> Comment on attachment 627447 [details] [diff] [review]
> v1
>
> Review of attachment 627447 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> I think the right place to be making this adjustment is in
> http://hg.mozilla.org/build/buildbot-configs/file/c8feab772b4b/mozilla-tests/
> config.py#l970
So, flipping the "'debug':True" on line 974 to "'debug':False" would stop the four debug build runs, yeah?
I'm not quite sure how to stop the three not-mozilla-central tests from running while still letting the mozilla-central one run. Is there some syntax that can prevent certain branches from running on specific platforms in that file?
Updated•13 years ago
|
Assignee: nobody → kmoir
Assignee | ||
Comment 4•12 years ago
|
||
With bsmedbergs' revised plan, even though we're keeping win64 builds, we're switching off tests. As such we can just fix this by not testing jetpack on win64 at all.
Summary: Stop trying to do tests on the Jetpack tree on platforms that don't exist → Stop running tests on the Jetpack tree on Win64
Assignee | ||
Comment 5•12 years ago
|
||
Assignee: kmoir → edmorley.bz
Attachment #627447 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #696996 -
Flags: review?(catlee)
Updated•12 years ago
|
Attachment #696996 -
Flags: review?(catlee) → review+
Assignee | ||
Comment 6•12 years ago
|
||
Comment on attachment 696996 [details] [diff] [review]
Don't test on win64
https://hg.mozilla.org/build/buildbot-configs/rev/790aacee9944
Attachment #696996 -
Flags: checked-in+
Comment 7•12 years ago
|
||
in production
Assignee | ||
Comment 8•12 years ago
|
||
Thank you, looks good:
https://tbpl.mozilla.org/?tree=Jetpack&noignore=1&rev=037a5be94fea
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Product: mozilla.org → Release Engineering
Updated•7 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•