Last Comment Bug 737686 - Avoid using glTexSubImage on PowerVR
: Avoid using glTexSubImage on PowerVR
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: mozilla14
Assigned To: Jeff Muizelaar [:jrmuizel]
:
: Milan Sreckovic [:milan]
Mentors:
Depends on: 737437
Blocks: checkerboarding 729391
  Show dependency treegraph
 
Reported: 2012-03-20 16:19 PDT by Jeff Muizelaar [:jrmuizel]
Modified: 2012-04-02 08:48 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Disable glTexSubImage2D on PowerVR (1.66 KB, patch)
2012-03-20 16:19 PDT, Jeff Muizelaar [:jrmuizel]
gwright: review+
Details | Diff | Splinter Review

Description Jeff Muizelaar [:jrmuizel] 2012-03-20 16:19:22 PDT
Created attachment 607765 [details] [diff] [review]
Disable glTexSubImage2D on PowerVR

glTexSubImage causes a readback on PowerVR hardware if the texture has already been uploaded. Disabling CanUploadSubTextures() brings the median upload speed from 26ms to 10ms.

It's possible this may cause bug 727688 again. We'll need to watch for it.
Comment 1 George Wright (:gw280) (:gwright) 2012-03-20 16:58:09 PDT
Comment on attachment 607765 [details] [diff] [review]
Disable glTexSubImage2D on PowerVR

Review of attachment 607765 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm
Comment 2 George Wright (:gw280) (:gwright) 2012-03-20 16:58:20 PDT
Comment on attachment 607765 [details] [diff] [review]
Disable glTexSubImage2D on PowerVR

Review of attachment 607765 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm
Comment 3 Jeff Muizelaar [:jrmuizel] 2012-03-21 15:09:45 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/80a7d26b02ec
Comment 4 Marco Bonardo [::mak] 2012-03-22 06:36:35 PDT
https://hg.mozilla.org/mozilla-central/rev/80a7d26b02ec
Comment 5 Ali Juma [:ajuma] 2012-03-25 08:02:09 PDT
This is causing Bug 737437 on PowerVR devices.
Comment 6 George Wright (:gw280) (:gwright) 2012-03-25 17:33:19 PDT
are we running out of memory?

Note You need to log in before you can comment on or make changes to this bug.