Closed Bug 737686 Opened 8 years ago Closed 8 years ago

Avoid using glTexSubImage on PowerVR

Categories

(Core :: Graphics, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: jrmuizel, Assigned: jrmuizel)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

glTexSubImage causes a readback on PowerVR hardware if the texture has already been uploaded. Disabling CanUploadSubTextures() brings the median upload speed from 26ms to 10ms.

It's possible this may cause bug 727688 again. We'll need to watch for it.
Attachment #607765 - Flags: review?(gwright)
Blocks: 729391
Comment on attachment 607765 [details] [diff] [review]
Disable glTexSubImage2D on PowerVR

Review of attachment 607765 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm
Attachment #607765 - Flags: review?(gwright) → review+
Comment on attachment 607765 [details] [diff] [review]
Disable glTexSubImage2D on PowerVR

Review of attachment 607765 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm
Assignee: nobody → jmuizelaar
https://hg.mozilla.org/mozilla-central/rev/80a7d26b02ec
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
Depends on: 737437
This is causing Bug 737437 on PowerVR devices.
are we running out of memory?
You need to log in before you can comment on or make changes to this bug.