Avoid using glTexSubImage on PowerVR

RESOLVED FIXED in mozilla14

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Tracking

(Blocks: 1 bug)

unspecified
mozilla14
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 607765 [details] [diff] [review]
Disable glTexSubImage2D on PowerVR

glTexSubImage causes a readback on PowerVR hardware if the texture has already been uploaded. Disabling CanUploadSubTextures() brings the median upload speed from 26ms to 10ms.

It's possible this may cause bug 727688 again. We'll need to watch for it.
Attachment #607765 - Flags: review?(gwright)
(Assignee)

Updated

5 years ago
Blocks: 729391
Comment on attachment 607765 [details] [diff] [review]
Disable glTexSubImage2D on PowerVR

Review of attachment 607765 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm
Attachment #607765 - Flags: review?(gwright) → review+
Comment on attachment 607765 [details] [diff] [review]
Disable glTexSubImage2D on PowerVR

Review of attachment 607765 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm
(Assignee)

Updated

5 years ago
Assignee: nobody → jmuizelaar
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/80a7d26b02ec
https://hg.mozilla.org/mozilla-central/rev/80a7d26b02ec
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14

Updated

5 years ago
Depends on: 737437

Comment 5

5 years ago
This is causing Bug 737437 on PowerVR devices.
are we running out of memory?
(Assignee)

Updated

5 years ago
Blocks: 717774
You need to log in before you can comment on or make changes to this bug.