The default bug view has changed. See this FAQ.

nsMailboxUrl should treat fetch-part URLs as "eDisplay"

RESOLVED FIXED in Thunderbird 14.0

Status

MailNews Core
Attachments
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: squib, Assigned: squib)

Tracking

Thunderbird 14.0
x86_64
Linux
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 607767 [details] [diff] [review]
Fix this

Currently, opening an attached message from a local message doesn't fire onEndMsgDownload, which causes a few problems:

* The phishing detector is never run
* Big images aren't resized to fit the screen
* Mozmill tests can't use wait_for_message_display_completion

Here's a patch to fix this, which also adds a Mozmill test for the phishing detector.
Attachment #607767 - Flags: review?(dbienvenu)
(Assignee)

Updated

5 years ago
Assignee: nobody → squibblyflabbetydoo
Status: NEW → ASSIGNED

Comment 1

5 years ago
Comment on attachment 607767 [details] [diff] [review]
Fix this

what if we're fetching a non attached message part, i.e., any other kind of attachment? Maybe we should check the content type as well (message/rfc822)

-      *isType = (m_mailboxAction == nsIMailboxUrl::ActionFetchMessage);
+      *isType = (m_mailboxAction == nsIMailboxUrl::ActionFetchMessage ||
+                 m_mailboxAction == nsIMailboxUrl::ActionFetchPart);

Comment 2

5 years ago
Comment on attachment 607767 [details] [diff] [review]
Fix this

yeah, opening an attached jpg in a local mail message triggers the nsMsgStatusFeedback::OnStateChange code, which I don't think is the right thing.
Attachment #607767 - Flags: review?(dbienvenu) → review-
(Assignee)

Comment 3

5 years ago
(In reply to David :Bienvenu from comment #2)
> Comment on attachment 607767 [details] [diff] [review]
> Fix this
> 
> yeah, opening an attached jpg in a local mail message triggers the
> nsMsgStatusFeedback::OnStateChange code, which I don't think is the right
> thing.

It looks like this happens with nsImapUrls too, but that they don't have a msgWindow set in that case, so we never get to OnEndMsgDownload.
(Assignee)

Comment 4

5 years ago
Created attachment 608241 [details] [diff] [review]
Make nsMailboxUrl behave more like nsImapUrl

Based on my debug printf()s, I think this makes mailbox URLs work like IMAP URLs, which seems like a good goal.

Here's a try build to ensure I didn't totally break things: http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=6138e7d5e0bb
Attachment #607767 - Attachment is obsolete: true
Attachment #608241 - Flags: review?(dbienvenu)

Updated

5 years ago
Attachment #608241 - Flags: review?(dbienvenu) → review+
(Assignee)

Comment 5

5 years ago
Checked in: http://hg.mozilla.org/comm-central/rev/104c0b09c833
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
You need to log in before you can comment on or make changes to this bug.