Last Comment Bug 737793 - Final call state on receiver's phone is 'disconnecting', not 'disconnected'
: Final call state on receiver's phone is 'disconnecting', not 'disconnected'
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: unspecified
: ARM Gonk (Firefox OS)
: -- normal (vote)
: mozilla14
Assigned To: Hsin-Yi Tsai [:hsinyi]
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-21 03:22 PDT by Hsin-Yi Tsai [:hsinyi]
Modified: 2012-03-24 13:40 PDT (History)
6 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Made the final call state on receiver's phone to disconnected (1.89 KB, patch)
2012-03-21 04:11 PDT, Hsin-Yi Tsai [:hsinyi]
no flags Details | Diff | Splinter Review
logcat of the patch (32.30 KB, text/plain)
2012-03-21 04:12 PDT, Hsin-Yi Tsai [:hsinyi]
no flags Details
[Updated] Patch_Bug 737793 (974 bytes, patch)
2012-03-21 04:35 PDT, Hsin-Yi Tsai [:hsinyi]
bent.mozilla: review+
Details | Diff | Splinter Review

Description Hsin-Yi Tsai [:hsinyi] 2012-03-21 03:22:45 PDT
If you start two emulators and have one call the other, then have the receiver answer the call and then hang up, the call on the caller's phone correctly proceeds to the 'disconnected' state, but the receiver's call only proceeds to 'disconnecting' and never reaches 'disconnected'. This is reflected in the UI by the dialer app never returning to the main screen (the red 'hang up' button is forever displayed).
Comment 1 Hsin-Yi Tsai [:hsinyi] 2012-03-21 04:11:19 PDT
Created attachment 607901 [details] [diff] [review]
Made the final call state on receiver's phone to disconnected

After Receiver hangs up the call, receiver gets a response of REQUEST_HANGUP. Then, receiver should get an unsolicited response to update the call state from rild. But that didn't happen in this bug. 

This patch |getCurrentCalls()| to update the call state actively after REQUEST_HANGUP. Then, the final call state on Receiver's phone can reach "disconnected."
Comment 2 Hsin-Yi Tsai [:hsinyi] 2012-03-21 04:12:42 PDT
Created attachment 607902 [details]
logcat of the patch
Comment 3 Hsin-Yi Tsai [:hsinyi] 2012-03-21 04:35:56 PDT
Created attachment 607906 [details] [diff] [review]
[Updated] Patch_Bug 737793

Unnecessary debug messages have been removed in this update version. Thanks!
Comment 4 Hsin-Yi Tsai [:hsinyi] 2012-03-23 00:01:35 PDT
CCing Chris Jones for my "Commit Access (Level 1)". Thanks!
Comment 5 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-03-23 02:02:26 PDT
Please file a separate bug for getting level 1 commit access.
Comment 6 Ryan VanderMeulen [:RyanVM] 2012-03-23 19:04:39 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/c38c2569a026
Comment 7 Ed Morley [:emorley] 2012-03-24 13:40:06 PDT
https://hg.mozilla.org/mozilla-central/rev/c38c2569a026

Note You need to log in before you can comment on or make changes to this bug.