737798 - Adding a breakpoint in a non-sensical place briefly shows the icon

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

Adding a breakpoint in the editor in a line that does not contain a script (or where setBreakpoint returns an error) briefly flashes the icon. It would be best if we didn't show the icon until we got a successful response from setBreakpoint.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

After some more discussion with Mihai, we agreed that delaying the display of the icon would be worse in remote debugging scenarios, because the user wouldn't get any feedback for quite some time. We could show a greyed-out or semi-transparent icon until we get a response from the server and either display the normal icon on success, or hide it on failure.

Comment 2

[Rob Campbell [:rc] (:robcee)]

yeah, that sounds good. We should have *some* form of immediate feedback so the user doesn't feel compelled to keep clicking and sending multiple set/clear breakpoint requests to the server.

Comment 3

[Victor Porof [:vporof][:vp]]

Bug 799077 is related. Maybe a dupe.

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

Actually the behavior described in comment 0 no longer exists. We now set a breakpoint always, because a scavenged script may exist at that line and reappear after a reload.