737809 - release sanity should check if the current release is runnable on the current master

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Rail Aliiev [:rail]]

... by reading master.json and comparing release_branches with the version in configs and command line.

Comment 1

[Chris AtLee [:catlee]]

we hit this on the 12.0b2 release, accidentally kicking off builds on the wrong master.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [tools] add check in release sanity

Comment 3

[Chris AtLee [:catlee]]

Comment on attachment 608584 [details] [diff] [review]
[tools] add check in release sanity

Review of attachment 608584 [details] [diff] [review]:
-----------------------------------------------------------------

::: buildbot-helpers/release_sanity.py
@@ +84,5 @@
>      run_cmd(cmd)
>  
> +def verify_branch(branch, productName):
> +    masterConfig = json.load(open('master_config.json'))
> +    if (productName != 'fennec' and branch not in masterConfig['release_branches']) or \

safe to say if productName == 'firefox' here?

@@ +87,5 @@
> +    masterConfig = json.load(open('master_config.json'))
> +    if (productName != 'fennec' and branch not in masterConfig['release_branches']) or \
> +       (productName == 'fennec' and branch not in masterConfig['mobile_release_branches']):
> +        success = False
> +        log.error("branch %s isn't enabled for %s" % (branch, productName))

you can also do
log.error("branch %s isn't enabled for %s", branch, productName)

which for some reason I find easier to write

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 608584 [details] [diff] [review]
[tools] add check in release sanity

(In reply to Chris AtLee [:catlee] from comment #3)
> > +    if (productName != 'fennec' and branch not in masterConfig['release_branches']) or \
> safe to say if productName == 'firefox' here?

That works, but I wrote it this way to avoid breaking thunderbird/seamonkey.
 
> you can also do
>   log.error("branch %s isn't enabled for %s", branch, productName)
> which for some reason I find easier to write

That's much nicer, so I did that in 
 http://hg.mozilla.org/build/tools/rev/e4b03abe54fc