Closed Bug 737812 Opened 12 years ago Closed 9 years ago

post_upload.py shouldn't override release files

Categories

(Release Engineering :: Release Automation: Other, defect, P5)

Product:
Release Engineering
Component:
Release Automation: Other
Platform:
x86_64
Linux
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: rail, Unassigned)

References

Details

(Whiteboard: [releases][automation][stage])

Attachments

(3 files, 1 obsolete file)

mac xulrunner make upload
42.00 KB, text/html
Details
tools
19.35 KB, patch
bhearsum
: feedback+
Details | Diff | Splinter Review
buildbotcustom
2.33 KB, patch
bhearsum
: feedback+
Details | Diff | Splinter Review
Attached patch don't override release fiels (obsolete) — — Splinter Review 
We should cleanup directories manually in edge case not allowing automation to override existing files.

To be tested.
Attachment #607914 - Flags: feedback?(catlee)
Priority: -- → P3
Comment on attachment 607914 [details] [diff] [review]
don't override release fiels

Marking f+ after we talked about it and decided to test it in staging.
Attachment #607914 - Flags: feedback?(catlee) → feedback+
Bulk move of bugs to Release Automation component.
Component: Release Engineering: Automation (General) → Release Engineering: Automation (Release Automation)
Checked a staging release log was running over the weekend and found that mac xulrunner's make upload tries to overwrite xulrunner-*.en-US.mac-pkg.dmg while running second make upload from obj-firefox/x86_64. It also tries to overwrite *.checksums files, what means that production xulrunner checksum files don't have all entries, see http://stage.mozilla.org/pub/mozilla.org/xulrunner/nightly/10.0-candidates/build1/runtimes/xulrunner-10.0.en-US.mac-pkg.checksums.
Depends on: 742278
Priority: P3 → P5
Not working on this bug actively. May grab it once xulrunner make upload logic is fixed.
Assignee: rail → nobody
Another idea is to explicitly pass --dont-overwrite parameter to post_upload.py and set it for non XR release builds.
Assignee: nobody → rail
Or pass '--enable-overwrite' and set it only for XR release builds.
Attached patch tools — — Splinter Review 
to be tested
Attachment #607914 - Attachment is obsolete: true
Attached patch buildbotcustom — — Splinter Review 

    
    

    
  
Comment on attachment 677438 [details] [diff] [review]
tools

I haven't tested the patches yet.

        Attachment #677438 -
        Flags: feedback?(bhearsum)

    
    

    
  
Comment on attachment 677439 [details] [diff] [review]
buildbotcustom

xulrunner (the only product which supposed to be allowed to overwrite the files due to the blocker bug) constructs its own POST_UPLOAD_CMD

        Attachment #677439 -
        Flags: feedback?(bhearsum)

        Attachment #677439 -
        Flags: feedback?(bhearsum) → feedback+

        Attachment #677438 -
        Flags: feedback?(bhearsum) → feedback+

    
    

    
  
back to the pool
Assignee: rail → nobody

    
    

    
  
Mass re-assign of post_upload.py bugs to Tomcat.
Assignee: nobody → cbook
Assignee: cbook → nobody
Product: mozilla.org → Release Engineering

    
    

    
  
Release promotion is going to bypass post_upload.py, not relevant anymore.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: