Closed Bug 737877 Opened 13 years ago Closed 5 years ago

[New Tab Page] thumbnails disappear with browser.display.use_document_colors=false

Categories

(Firefox :: New Tab Page, defect)

Product:
Firefox
Component:
New Tab Page
Version:
13 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: rig9919hd, Unassigned)

Details

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:13.0) Gecko/20120321 Firefox/13.0a2
Build ID: 20120321051052

Steps to reproduce:

Disable "allow pages to choose their own colors" in content preferences.
Opened new tab page.


Actual results:

I see empty squares with website titles in them, but no images.


Expected results:

I should see the thumbnails of the websites along with the titles in the squares.
Same problem in Private Mode, regardless of whether "allow pages to choose their own colors" is enabled or not.
Confirming on Win XP, the "allow pages to choose their own colors" case.

Enabling that option again makes the thumbnails appear even on already open newtab. Maybe the images are used as background.
Status: UNCONFIRMED → NEW
Component: Untriaged → Layout
Ever confirmed: true
OS: Linux → All
Product: Firefox → Core
QA Contact: untriaged → layout
Hardware: x86_64 → All
Why is this a layout issue?  Seems like a basic problem with how Firefox implements the new tab page...  It makes it look like a web page (content-type docshell), so it gets treated as one by the style system.
Component: Layout → General
Product: Core → Firefox
QA Contact: layout → general
Component: General → Untriaged
QA Contact: general → untriaged
Component: Untriaged → Tabbed Browser
QA Contact: untriaged → tabbed.browser
Summary: website thumbnails on new tab page don't show when "allow pages to choose their own colors" is disabled → [New Tab Page] thumbnails don't show when "allow pages to choose their own colors" is disabled (browser.display.use_document_colors)
(In reply to Boris Zbarsky (:bz) from comment #3)
> Why is this a layout issue?  Seems like a basic problem with how Firefox
> implements the new tab page...  It makes it look like a web page
> (content-type docshell), so it gets treated as one by the style system.

Ok, so how could we fix this? Any pointers appreciated.
Depends on: 306625
Summary: [New Tab Page] thumbnails don't show when "allow pages to choose their own colors" is disabled (browser.display.use_document_colors) → [New Tab Page] thumbnails disappear with browser.display.use_document_colors=false
No longer depends on: 306625
> Ok, so how could we fix this?

Load chrome documents in type="chrome" browsers.  That's what you're supposed to do with parts of the browser UI.  There are existing longstanding bugs about that....
We could fix this by using real images instead of background images.
Mass-move to Firefox::New Tab Page.

Filter on new-tab-page-component.
Component: Tabbed Browser → New Tab Page

Closing since this applies to UI that no longer exists.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.