737909 - Fix opt -Werror build with clang

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: Use abort() instead of assert(0)

The cairo codebase has no general way to mark a place as unreachable (like  MOZ_NOT_REACHED), so I just used a known noreturn function that exits on opt builds too (abort).

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 607997 [details] [diff] [review]
Use abort() instead of assert(0)

I'd rather us just not build cairo with -Werror. Is that possible?

Comment 2

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: alternative patch

Turns out that the problem is not a general -Werror, but -Werror=return-type. The bad news is that we don't have support for building just cairo without it. The good news is that it is easier to avoid. The attached patch just adds a dummy return.

Comment 3

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: alternative patch

Comment 4

[Gregor Wagner [:gwagner]]

Can we get this on mc please?

Comment 5

[Joe Drew (not getting mail)]

Comment on attachment 608065 [details] [diff] [review]
alternative patch

Return kPrivateCGCompositeClear instead.

We also need to add a patch to gfx/cairo/

Comment 6

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/5203c29c114a
https://hg.mozilla.org/mozilla-central/rev/da235c17d8a8
https://hg.mozilla.org/mozilla-central/rev/11ffc371ff2e