The default bug view has changed. See this FAQ.

Fix opt -Werror build with clang

RESOLVED FIXED in mozilla14

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: espindola, Assigned: espindola)

Tracking

unspecified
mozilla14
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Created attachment 607997 [details] [diff] [review]
Use abort() instead of assert(0)

The cairo codebase has no general way to mark a place as unreachable (like  MOZ_NOT_REACHED), so I just used a known noreturn function that exits on opt builds too (abort).
Attachment #607997 - Flags: review?(jmuizelaar)
Comment on attachment 607997 [details] [diff] [review]
Use abort() instead of assert(0)

I'd rather us just not build cairo with -Werror. Is that possible?
Created attachment 608063 [details] [diff] [review]
alternative patch

Turns out that the problem is not a general -Werror, but -Werror=return-type. The bad news is that we don't have support for building just cairo without it. The good news is that it is easier to avoid. The attached patch just adds a dummy return.
Assignee: nobody → respindola
Status: NEW → ASSIGNED
Attachment #608063 - Flags: review?(jmuizelaar)
Created attachment 608065 [details] [diff] [review]
alternative patch
Attachment #608063 - Attachment is obsolete: true
Attachment #608063 - Flags: review?(jmuizelaar)
Attachment #608065 - Flags: review?(jmuizelaar)
Can we get this on mc please?
Comment on attachment 608065 [details] [diff] [review]
alternative patch

Return kPrivateCGCompositeClear instead.

We also need to add a patch to gfx/cairo/
Attachment #608065 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/mozilla-central/rev/5203c29c114a
https://hg.mozilla.org/mozilla-central/rev/da235c17d8a8
https://hg.mozilla.org/mozilla-central/rev/11ffc371ff2e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
Attachment #607997 - Flags: review?(jmuizelaar)
You need to log in before you can comment on or make changes to this bug.