Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Shrink bits for CACHED_PROTO_KEYs and add two new JSClass flags for the new DOM bindings

RESOLVED FIXED in mozilla14

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ben Turner (not reading bugmail, use the needinfo flag!), Assigned: Ben Turner (not reading bugmail, use the needinfo flag!))

Tracking

unspecified
mozilla14
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 608000 [details] [diff] [review]
Patch, v1

The new DOM bindings need two JSClass bits at the moment, one to tell us that we have a subclass of JSClass and the other to tell us if the object has extra reserved slots for our prototype check mechanism. Eventually when we switch Window to use the new bindings we can remove the second bit.

I talked with waldo about this yesterday and he recommended shrinking the number of bits for the cached proto key stuff in order to open up two more bits. Patch attached.
Attachment #608000 - Flags: review?(jwalden+bmo)
Created attachment 610306 [details] [diff] [review]
Patch, v2

Fixed the way luke liked it!
Attachment #608000 - Attachment is obsolete: true
Attachment #608000 - Flags: review?(jwalden+bmo)
Attachment #610306 - Flags: review?(luke)

Comment 2

5 years ago
Comment on attachment 610306 [details] [diff] [review]
Patch, v2

Great, thanks!
Attachment #610306 - Flags: review?(luke) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/a5c5bc683072

Updated

5 years ago
Blocks: 740069
https://hg.mozilla.org/mozilla-central/rev/a5c5bc683072
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.