Closed Bug 737911 Opened 11 years ago Closed 11 years ago

Shrink bits for CACHED_PROTO_KEYs and add two new JSClass flags for the new DOM bindings

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla14

People

(Reporter: bent.mozilla, Assigned: bent.mozilla)

References

Details

Attachments

(1 file, 1 obsolete file)

Patch, v2
3.58 KB, patch
luke
: review+
Details | Diff | Splinter Review
Attached patch Patch, v1 (obsolete) — — Splinter Review 
The new DOM bindings need two JSClass bits at the moment, one to tell us that we have a subclass of JSClass and the other to tell us if the object has extra reserved slots for our prototype check mechanism. Eventually when we switch Window to use the new bindings we can remove the second bit.

I talked with waldo about this yesterday and he recommended shrinking the number of bits for the cached proto key stuff in order to open up two more bits. Patch attached.
Attachment #608000 - Flags: review?(jwalden+bmo)
Attached patch Patch, v2 — — Splinter Review 
Fixed the way luke liked it!
Attachment #608000 - Attachment is obsolete: true
Attachment #608000 - Flags: review?(jwalden+bmo)
Attachment #610306 - Flags: review?(luke)
Comment on attachment 610306 [details] [diff] [review]
Patch, v2

Great, thanks!
Attachment #610306 - Flags: review?(luke) → review+
https://hg.mozilla.org/mozilla-central/rev/a5c5bc683072
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.