737927 - Firebug blocklist item isn't being downloaded

Status: RESOLVED FIXED

(Toolkit :: Blocklist Policy Requests, defect)

Description

[Jorge Villalobos [:jorgev] (he/him)]

I created a blocklist entry for Firebug 1.9.0 per bug 718831, but it is not being downloaded in any versions of Firefox I've tried. It is limited for Mac OS X and Linux, but as far as I can tell the whole blocklist is always downloaded so it shouldn't be a problem (I'm testing in Mac OS X, Firefox 9, which should apply anyway).

We need to figure out if there's anything wrong with the blocklist entry that would cause it to not be served at all, or if there's something else going on.

Comment 1

[Justin Scott [:fligtar]]

I don't see any item details associated with the block: https://addons.mozilla.org/en-US/admin/models/blocklist/blocklistdetail/74/

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

(In reply to Justin Scott [:fligtar] from comment #1)
> I don't see any item details associated with the block:
> https://addons.mozilla.org/en-US/admin/models/blocklist/blocklistdetail/74/

What do you mean by that? Do the blocklist items section need to have the same data as this: 
https://addons.mozilla.org/en-US/admin/models/blocklist/blocklistitem/64/

Comment 3

[Justin Scott [:fligtar]]

Blocks should be added using the blocklistdetails page so that the metadata is associated with the item. If there are separate entries they should be combined under a single blocklistdetails item.

Comment 4

[Jorge Villalobos [:jorgev] (he/him)]

Previous blocks I added are working correctly even when set this way.

I deleted the blocklist entry and recreated it following the indications in comment #3, but the item still doesn't show up in blocklist.xml.

Comment 5

[Justin Scott [:fligtar]]

Yeahhh I don't know what's wrong then. Everything looks right to me.

Comment 6

[Jorge Villalobos [:jorgev] (he/him)]

Who can look into the server code and see what's wrong?

Comment 7

[Rob Hudson [:robhudson]]

Jorge: I don't have admin access on the prod server, but if you duplicate the entry on -dev or show me what you entered, I can test it locally and see if there's any issues or try to debug why it's not showing up.

Comment 8

[krupa raj[:krupa]]

On doing a blocklist ping, I see a CSP: Couldn't parse invalid host on addons-dev-cdn.allozom.org error in my Error Console.

Comment 9

[Jorge Villalobos [:jorgev] (he/him)]

(In reply to Rob Hudson [:robhudson] from comment #7)
> Jorge: I don't have admin access on the prod server, but if you duplicate
> the entry on -dev or show me what you entered, I can test it locally and see
> if there's any issues or try to debug why it's not showing up.

It's up now: https://addons-dev.allizom.org/en-US/firefox/blocked/i74

(In reply to krupa raj 82[:krupa] from comment #8)
> On doing a blocklist ping, I see a CSP: Couldn't parse invalid host on
> addons-dev-cdn.allozom.org error in my Error Console.

That shouldn't be a problem. While testing other blocks, the error shows up but the blocklist is refreshed correctly.

Comment 10

[Wil Clouser [:clouserw]]

(In reply to Jorge Villalobos [:jorgev] from comment #9)
> (In reply to Rob Hudson [:robhudson] from comment #7)
> > Jorge: I don't have admin access on the prod server, but if you duplicate
> > the entry on -dev or show me what you entered, I can test it locally and see
> > if there's any issues or try to debug why it's not showing up.
> 
> It's up now: https://addons-dev.allizom.org/en-US/firefox/blocked/i74

I think that means this is fixed.