Fastest Search leaves Zombie Compartments

RESOLVED FIXED

Status

Tech Evangelism
Add-ons
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: eviljeff, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [MemShrink:P3], URL)

(Reporter)

Description

5 years ago
Fastest Search addon leaves Zombie Compartments during use.

Steps to Reproduce:
1) install addon and load a page into a tab (e.g. http://www.mozilla.org/en-US/about/partnerships.html)
2) Press Ctrl+Shift+F to activate addon.  
3) search for something (e.g. Firefox)
4) close tab
5) open about:memory?verbose
6) hit 'minimise memory usage' button a few times
7) see reference to closed tab still

The add-on also remains in memory on disable though that will probably be fixed by using an up-to-date SDK version (1.5)

Developer cc'd and notified via review.
Whiteboard: [MemShrink]

Comment 1

5 years ago
I just fixed the issue and tested in FF13.0a2 through both about:compartments?verbose and about:memory?verbose. It was a simple case of reference to the currently searched page not removed after text search is done. I'll soon repack and submit the newer version. Thanks for finding my oversight!
Whiteboard: [MemShrink] → [MemShrink:P3]
Component: General → Add-ons
Product: Core → Tech Evangelism
Version: Trunk → unspecified
Version 1.6 of the SDK is now available. This version should address the pending memory leaks in your add-on. Please upgrade your add-on to use SDK 1.6 and submit a new version as soon as possible.

Comment 3

5 years ago
I'm aware of that and in fact already have a SDK1.6-packed version yesterday that's free of memory leaks, but I'm also trying to put in a few small new features and squash some old bugs. I'm very eager to get this new version out too & I expect to release it some time this weekend, after more testing and potential fixing.

Comment 4

5 years ago
As promised, FS v2.10 was just released at https://addons.mozilla.org/en-US/firefox/addon/fastest-search/versions/2.10
(Reporter)

Comment 5

5 years ago
2.10 fixes both the zombie compartments on use and references remaining on disable/uninstall issues so marking as fixed.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.