"Assertion failure: rt->gcMode != JSGC_MODE_GLOBAL" with certain GC prefs and gczeal

RESOLVED FIXED in mozilla14

Status

()

Core
JavaScript Engine
--
critical
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Jesse Ruderman, Assigned: billm)

Tracking

({assertion, testcase})

Trunk
mozilla14
x86_64
Mac OS X
assertion, testcase
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

6 years ago
Created attachment 608055 [details]
testcase

1. Install the new new version of 
  https://www.squarefree.com/extensions/domFuzzLite3.xpi

2. Set

user_pref("javascript.options.mem.gc_per_compartment", false);

3. Load the testcase.

Result:
Assertion failure: rt->gcMode != JSGC_MODE_GLOBAL, at jsgc.cpp:3618
(Assignee)

Updated

6 years ago
Assignee: general → wmccloskey
(Assignee)

Comment 1

6 years ago
Created attachment 609455 [details] [diff] [review]
fix
Attachment #609455 - Flags: review?(igor)
(Assignee)

Comment 2

6 years ago
Sorry, hit enter too fast.

It seems silly that callers of js::GC have to worry about the GC mode. This patch just moves the checks into Collect, so that we only have to remember to check in one place.

Updated

6 years ago
Attachment #609455 - Flags: review?(igor) → review+
(Assignee)

Comment 3

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/e09acca2c2c1
Target Milestone: --- → mozilla14

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/e09acca2c2c1
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.