Last Comment Bug 737997 - "Assertion failure: rt->gcMode != JSGC_MODE_GLOBAL" with certain GC prefs and gczeal
: "Assertion failure: rt->gcMode != JSGC_MODE_GLOBAL" with certain GC prefs and...
Status: RESOLVED FIXED
: assertion, testcase
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: x86_64 Mac OS X
: -- critical (vote)
: mozilla14
Assigned To: Bill McCloskey (:billm)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-21 12:27 PDT by Jesse Ruderman
Modified: 2012-03-27 05:19 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
testcase (70 bytes, text/html)
2012-03-21 12:27 PDT, Jesse Ruderman
no flags Details
fix (2.02 KB, patch)
2012-03-26 13:23 PDT, Bill McCloskey (:billm)
igor: review+
Details | Diff | Review

Description Jesse Ruderman 2012-03-21 12:27:16 PDT
Created attachment 608055 [details]
testcase

1. Install the new new version of 
  https://www.squarefree.com/extensions/domFuzzLite3.xpi

2. Set

user_pref("javascript.options.mem.gc_per_compartment", false);

3. Load the testcase.

Result:
Assertion failure: rt->gcMode != JSGC_MODE_GLOBAL, at jsgc.cpp:3618
Comment 1 Bill McCloskey (:billm) 2012-03-26 13:23:17 PDT
Created attachment 609455 [details] [diff] [review]
fix
Comment 2 Bill McCloskey (:billm) 2012-03-26 13:24:55 PDT
Sorry, hit enter too fast.

It seems silly that callers of js::GC have to worry about the GC mode. This patch just moves the checks into Collect, so that we only have to remember to check in one place.
Comment 4 Ed Morley [:emorley] 2012-03-27 05:19:19 PDT
https://hg.mozilla.org/mozilla-central/rev/e09acca2c2c1

Note You need to log in before you can comment on or make changes to this bug.