737997 - "Assertion failure: rt->gcMode != JSGC_MODE_GLOBAL" with certain GC prefs and gczeal

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jesse Ruderman]

Attachment: testcase

1. Install the new new version of 
  https://www.squarefree.com/extensions/domFuzzLite3.xpi

2. Set

user_pref("javascript.options.mem.gc_per_compartment", false);

3. Load the testcase.

Result:
Assertion failure: rt->gcMode != JSGC_MODE_GLOBAL, at jsgc.cpp:3618

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: fix

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Sorry, hit enter too fast.

It seems silly that callers of js::GC have to worry about the GC mode. This patch just moves the checks into Collect, so that we only have to remember to check in one place.

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e09acca2c2c1

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e09acca2c2c1