gonk gps - test GpsInterface size before using

RESOLVED FIXED in mozilla14

Status

()

Core
Geolocation
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dougt, Assigned: dougt)

Tracking

unspecified
mozilla14
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Changes:

Tests the resulting interface structure's size with what was compiled. I am seeing mismatches on the S2 which cause crashes.

Sets mStarted when the provide has started up.

Moves the code that dlopen's from the provider's constructor to Startup().
(Assignee)

Comment 1

5 years ago
Created attachment 608076 [details] [diff] [review]
patch v.1
Attachment #608076 - Flags: review?(josh)

Comment 2

5 years ago
Comment on attachment 608076 [details] [diff] [review]
patch v.1

Review of attachment 608076 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/GonkGPSGeolocationProvider.cpp
@@ +187,5 @@
>  {
>    if (!mStarted)
>      return NS_OK;
>  
> +  NS_ENSURE_TRUE(mGpsInterface, NS_OK);

Just add this check to the one above.
Attachment #608076 - Flags: review?(josh) → review+
https://hg.mozilla.org/mozilla-central/rev/d5e83e501b01
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.