Last Comment Bug 738022 - gonk gps - test GpsInterface size before using
: gonk gps - test GpsInterface size before using
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Geolocation (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: mozilla14
Assigned To: Doug Turner (:dougt)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-21 13:35 PDT by Doug Turner (:dougt)
Modified: 2012-03-22 18:07 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch v.1 (2.24 KB, patch)
2012-03-21 13:36 PDT, Doug Turner (:dougt)
josh: review+
Details | Diff | Splinter Review

Description Doug Turner (:dougt) 2012-03-21 13:35:38 PDT
Changes:

Tests the resulting interface structure's size with what was compiled. I am seeing mismatches on the S2 which cause crashes.

Sets mStarted when the provide has started up.

Moves the code that dlopen's from the provider's constructor to Startup().
Comment 1 Doug Turner (:dougt) 2012-03-21 13:36:29 PDT
Created attachment 608076 [details] [diff] [review]
patch v.1
Comment 2 Josh Matthews [:jdm] 2012-03-21 21:27:16 PDT
Comment on attachment 608076 [details] [diff] [review]
patch v.1

Review of attachment 608076 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/GonkGPSGeolocationProvider.cpp
@@ +187,5 @@
>  {
>    if (!mStarted)
>      return NS_OK;
>  
> +  NS_ENSURE_TRUE(mGpsInterface, NS_OK);

Just add this check to the one above.
Comment 3 Marco Bonardo [::mak] 2012-03-22 18:07:23 PDT
https://hg.mozilla.org/mozilla-central/rev/d5e83e501b01

Note You need to log in before you can comment on or make changes to this bug.