Last Comment Bug 738072 - Use uint32_t for slot numbers, indexes, counts, etc.
: Use uint32_t for slot numbers, indexes, counts, etc.
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- minor (vote)
: mozilla14
Assigned To: general
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-21 16:11 PDT by Jeff Walden [:Waldo] (remove +bmo to email)
Modified: 2012-03-27 05:29 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (14.46 KB, patch)
2012-03-21 16:11 PDT, Jeff Walden [:Waldo] (remove +bmo to email)
dmandelin: review+
Details | Diff | Review

Description Jeff Walden [:Waldo] (remove +bmo to email) 2012-03-21 16:11:47 PDT
Created attachment 608132 [details] [diff] [review]
Patch

We limit slots to 32 bits, so we should use uint32_t for this, not size_t, unsigned, or whatever.  (Note that Shape::slot and other such things in jsscope.h already use uint32_t.)
Comment 1 Jeff Walden [:Waldo] (remove +bmo to email) 2012-03-26 12:25:07 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/1dca64d7943a
Comment 2 Marco Bonardo [::mak] 2012-03-27 05:29:13 PDT
https://hg.mozilla.org/mozilla-central/rev/1dca64d7943a

Note You need to log in before you can comment on or make changes to this bug.