Last Comment Bug 738118 - Don't duplicate 10.7 SDK shims
: Don't duplicate 10.7 SDK shims
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Widget: Cocoa (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla14
Assigned To: Paul O'Shannessy [:zpao] (not reading much bugmail, email directly)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-21 19:00 PDT by Paul O'Shannessy [:zpao] (not reading much bugmail, email directly)
Modified: 2012-03-22 06:47 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v0.1 (2.19 KB, patch)
2012-03-21 19:03 PDT, Paul O'Shannessy [:zpao] (not reading much bugmail, email directly)
jaas: review+
Details | Diff | Splinter Review

Description Paul O'Shannessy [:zpao] (not reading much bugmail, email directly) 2012-03-21 19:00:10 PDT
We started adding shims for 10.7 stuff in bug 674370 and then I landed bug 639705 yesterday with a separate set of #ifdefs. I had missed the other one when I rebased weeks ago :/
Comment 1 Paul O'Shannessy [:zpao] (not reading much bugmail, email directly) 2012-03-21 19:03:33 PDT
Created attachment 608183 [details] [diff] [review]
Patch v0.1

I liked Cameron's category name better - "LionWindowFeatures" > "NewInMacOS107" - so I used that.
Comment 2 Paul O'Shannessy [:zpao] (not reading much bugmail, email directly) 2012-03-21 19:47:29 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e6a12e21aa7
Comment 3 Marco Bonardo [::mak] 2012-03-22 06:47:44 PDT
https://hg.mozilla.org/mozilla-central/rev/5e6a12e21aa7

don't need to add [inbound] to the whiteboard

Note You need to log in before you can comment on or make changes to this bug.