Last Comment Bug 738137 - Try to create PBuffer offscreen context on NON-X11 builds always
: Try to create PBuffer offscreen context on NON-X11 builds always
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: ARM Linux
: -- normal (vote)
: mozilla14
Assigned To: Oleg Romashin (:romaxa)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-21 20:55 PDT by Oleg Romashin (:romaxa)
Modified: 2012-03-23 05:47 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Build PBuffer offscreen context if !MOZ_X11 (1.11 KB, patch)
2012-03-21 20:58 PDT, Oleg Romashin (:romaxa)
jgilbert: review+
Details | Diff | Review

Description Oleg Romashin (:romaxa) 2012-03-21 20:55:29 PDT
Right now we have this gate:
#if defined(ANDROID) || defined(XP_WIN)
which prevent us to create PBuffer on NON-X11 Linux platforms...

Would it make sense to do that always when X11 not defined?
Comment 1 Oleg Romashin (:romaxa) 2012-03-21 20:58:08 PDT
Created attachment 608214 [details] [diff] [review]
Build PBuffer offscreen context if !MOZ_X11
Comment 2 Jeff Gilbert [:jgilbert] 2012-03-22 10:27:46 PDT
Comment on attachment 608214 [details] [diff] [review]
Build PBuffer offscreen context if !MOZ_X11

Review of attachment 608214 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds reasonable. Push it by try.
Comment 3 Marco Bonardo [::mak] 2012-03-23 05:47:57 PDT
https://hg.mozilla.org/mozilla-central/rev/4b3912d5735a

Note You need to log in before you can comment on or make changes to this bug.