Closed
Bug 738153
Opened 12 years ago
Closed 12 years ago
Remove JSScript::inlineData
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
(Whiteboard: [MemShrink])
Attachments
(1 file)
5.07 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
AIUI, JSScript::inlineData was added in bug 674251 to avoid a Mac-only regression on a benchmark. Mac builds now use jemalloc, so that sensitivity shouldn't be a problem any more. Furthermore, removing inlineData reduces the size of JSScript on 64-bit from 208 bytes to 200 bytes. With 4064 bytes available for data per arena, this means we can fit 20 JSScripts per arena instead of 19. (If we halve JSScript size, as has been suggested for CPG, we'll fit 10 instead of 9). As for the memory savings made by storing the data inline -- only 2 or 3% of all JSScripts are small enough to fit inline. So the increase in memory consumption from storing tiny scripts out-of-line is negligible compared to the savings from fitting more JSScripts per arena.
Attachment #608236 -
Flags: review?(luke)
Comment 1•12 years ago
|
||
Comment on attachment 608236 [details] [diff] [review] patch Sweet
Attachment #608236 -
Flags: review?(luke) → review+
Assignee | ||
Comment 2•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1a79033e9c8
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d1a79033e9c8
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in
before you can comment on or make changes to this bug.
Description
•