738158 - Gallery app in Gaia doesn't show photos sometimes on Nexus S

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

STR
 (1) Load gallery
 (2) Tap image to "zoom in"
 (3) Drag back and forth

Symptom is that the screen goes back while the image is "animated".

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Remove unnecessary settings from InitTexture(). UploadSurfaceToTexture() and SetFilter/ApplyFilter() do these now

Removes redundant glTexImage() calls, but TBH probably doesn't make much of a difference.  Just cleanup.

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: part 2: Set the wrap mode for cairo images

Fixes the bug.  Apparently PowerVR SGX is more anal about setting the wrap mode than other drivers.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

https://hg.mozilla.org/integration/mozilla-inbound/rev/19ed27abdd23
https://hg.mozilla.org/integration/mozilla-inbound/rev/abd4103173a2

Comment 4

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/19ed27abdd23
https://hg.mozilla.org/mozilla-central/rev/abd4103173a2

hm, excuse the question, but what's [whiteboard] in the whiteboard for?

Comment 5

[Joe Drew (not getting mail)]

(In reply to Marco Bonardo [:mak] from comment #4)
> https://hg.mozilla.org/mozilla-central/rev/19ed27abdd23
> https://hg.mozilla.org/mozilla-central/rev/abd4103173a2
> 
> hm, excuse the question, but what's [whiteboard] in the whiteboard for?

no reason. Chris accidentally did it in bug 737071 and I thought it was hilarious. :)