Last Comment Bug 738158 - Gallery app in Gaia doesn't show photos sometimes on Nexus S
: Gallery app in Gaia doesn't show photos sometimes on Nexus S
Status: RESOLVED FIXED
[whiteboard [whiteboard]]
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: ARM Gonk (Firefox OS)
: -- normal (vote)
: mozilla14
Assigned To: Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
:
Mentors:
Depends on:
Blocks: 736716
  Show dependency treegraph
 
Reported: 2012-03-22 00:22 PDT by Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
Modified: 2012-03-24 02:16 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Remove unnecessary settings from InitTexture(). UploadSurfaceToTexture() and SetFilter/ApplyFilter() do these now (3.95 KB, patch)
2012-03-22 01:04 PDT, Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
ajuma.bugzilla: review+
Details | Diff | Review
part 2: Set the wrap mode for cairo images (1.02 KB, patch)
2012-03-22 01:05 PDT, Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
ajuma.bugzilla: review+
Details | Diff | Review

Description Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-03-22 00:22:21 PDT
STR
 (1) Load gallery
 (2) Tap image to "zoom in"
 (3) Drag back and forth

Symptom is that the screen goes back while the image is "animated".
Comment 1 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-03-22 01:04:21 PDT
Created attachment 608255 [details] [diff] [review]
Remove unnecessary settings from InitTexture().  UploadSurfaceToTexture() and SetFilter/ApplyFilter() do these now

Removes redundant glTexImage() calls, but TBH probably doesn't make much of a difference.  Just cleanup.
Comment 2 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-03-22 01:05:06 PDT
Created attachment 608256 [details] [diff] [review]
part 2: Set the wrap mode for cairo images

Fixes the bug.  Apparently PowerVR SGX is more anal about setting the wrap mode than other drivers.
Comment 4 Marco Bonardo [::mak] 2012-03-23 05:46:03 PDT
https://hg.mozilla.org/mozilla-central/rev/19ed27abdd23
https://hg.mozilla.org/mozilla-central/rev/abd4103173a2

hm, excuse the question, but what's [whiteboard] in the whiteboard for?
Comment 5 Joe Drew (not getting mail) 2012-03-23 10:28:58 PDT
(In reply to Marco Bonardo [:mak] from comment #4)
> https://hg.mozilla.org/mozilla-central/rev/19ed27abdd23
> https://hg.mozilla.org/mozilla-central/rev/abd4103173a2
> 
> hm, excuse the question, but what's [whiteboard] in the whiteboard for?

no reason. Chris accidentally did it in bug 737071 and I thought it was hilarious. :)

Note You need to log in before you can comment on or make changes to this bug.