Closed Bug 738178 Opened 9 years ago Closed 9 years ago

use BGRX shader for RGB24 image surfaces

Categories

(Core :: Graphics, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: gal, Assigned: gal)

Details

Attachments

(1 file)

The code is totally bizarre. I think this is better.
Attached patch patchSplinter Review
Assignee: nobody → gal
Please ignore the search key part.
Attachment #608280 - Flags: review?(jones.chris.g)
Comment on attachment 608280 [details] [diff] [review]
patch

Review of attachment 608280 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLContextProviderEGL.cpp
@@ +796,2 @@
>      case gfxASurface::ImageFormatRGB24:
> +        // Thebes only supports RGBX, not true RGB.

s/true/packed/
Attachment #608280 - Flags: review?(jones.chris.g) → review+
Right. Packed. I will learn the right gfx lingo eventually :)
Make sure to remove the b2g.js change before landing.
I really like that change and want to land it, but yes, separately.
https://hg.mozilla.org/mozilla-central/rev/7e6750f282cc
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.