Closed
Bug 738178
Opened 14 years ago
Closed 14 years ago
use BGRX shader for RGB24 image surfaces
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: gal, Assigned: gal)
Details
Attachments
(1 file)
|
2.23 KB,
patch
|
joe
:
review+
|
Details | Diff | Splinter Review |
The code is totally bizarre. I think this is better.
|
Assignee | |
Comment 1•14 years ago
|
||
Assignee: nobody → gal
|
|
Assignee | |
Comment 2•14 years ago
|
||
Please ignore the search key part.
|
|
Assignee | |
Updated•14 years ago
|
Attachment #608280 -
Flags: review?(jones.chris.g)
|
|
||
Comment 3•14 years ago
|
||
Comment on attachment 608280 [details] [diff] [review]
patch
Review of attachment 608280 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/gl/GLContextProviderEGL.cpp
@@ +796,2 @@
> case gfxASurface::ImageFormatRGB24:
> + // Thebes only supports RGBX, not true RGB.
s/true/packed/
Attachment #608280 -
Flags: review?(jones.chris.g) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Right. Packed. I will learn the right gfx lingo eventually :)
Make sure to remove the b2g.js change before landing.
|
|
Assignee | |
Comment 6•14 years ago
|
||
I really like that change and want to land it, but yes, separately.
|
|
Assignee | |
Comment 7•14 years ago
|
||
|
||
Comment 8•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in
before you can comment on or make changes to this bug.
Description
•