The default bug view has changed. See this FAQ.

use BGRX shader for RGB24 image surfaces

RESOLVED FIXED in mozilla14

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gal, Assigned: gal)

Tracking

Trunk
mozilla14
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

2.23 KB, patch
Joe Drew (not getting mail)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
The code is totally bizarre. I think this is better.
(Assignee)

Comment 1

5 years ago
Created attachment 608280 [details] [diff] [review]
patch
Assignee: nobody → gal
(Assignee)

Comment 2

5 years ago
Please ignore the search key part.
(Assignee)

Updated

5 years ago
Attachment #608280 - Flags: review?(jones.chris.g)
Comment on attachment 608280 [details] [diff] [review]
patch

Review of attachment 608280 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLContextProviderEGL.cpp
@@ +796,2 @@
>      case gfxASurface::ImageFormatRGB24:
> +        // Thebes only supports RGBX, not true RGB.

s/true/packed/
Attachment #608280 - Flags: review?(jones.chris.g) → review+
(Assignee)

Comment 4

5 years ago
Right. Packed. I will learn the right gfx lingo eventually :)
Make sure to remove the b2g.js change before landing.
(Assignee)

Comment 6

5 years ago
I really like that change and want to land it, but yes, separately.
(Assignee)

Comment 7

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/7e6750f282cc
https://hg.mozilla.org/mozilla-central/rev/7e6750f282cc
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.