Last Comment Bug 738178 - use BGRX shader for RGB24 image surfaces
: use BGRX shader for RGB24 image surfaces
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: mozilla14
Assigned To: Andreas Gal :gal
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-22 03:08 PDT by Andreas Gal :gal
Modified: 2012-03-22 18:18 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (2.23 KB, patch)
2012-03-22 03:08 PDT, Andreas Gal :gal
joe: review+
Details | Diff | Review

Description Andreas Gal :gal 2012-03-22 03:08:27 PDT
The code is totally bizarre. I think this is better.
Comment 1 Andreas Gal :gal 2012-03-22 03:08:45 PDT
Created attachment 608280 [details] [diff] [review]
patch
Comment 2 Andreas Gal :gal 2012-03-22 10:48:57 PDT
Please ignore the search key part.
Comment 3 Joe Drew (not getting mail) 2012-03-22 11:22:27 PDT
Comment on attachment 608280 [details] [diff] [review]
patch

Review of attachment 608280 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLContextProviderEGL.cpp
@@ +796,2 @@
>      case gfxASurface::ImageFormatRGB24:
> +        // Thebes only supports RGBX, not true RGB.

s/true/packed/
Comment 4 Andreas Gal :gal 2012-03-22 11:25:28 PDT
Right. Packed. I will learn the right gfx lingo eventually :)
Comment 5 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-03-22 11:30:00 PDT
Make sure to remove the b2g.js change before landing.
Comment 6 Andreas Gal :gal 2012-03-22 11:33:30 PDT
I really like that change and want to land it, but yes, separately.
Comment 8 Marco Bonardo [::mak] 2012-03-22 18:18:18 PDT
https://hg.mozilla.org/mozilla-central/rev/7e6750f282cc

Note You need to log in before you can comment on or make changes to this bug.