Last Comment Bug 738233 - Fix test for bug 329212
: Fix test for bug 329212
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: General (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Firefox 14
Assigned To: Ian Moody [:Kwan]
:
:
Mentors:
Depends on:
Blocks: 329212 601091
  Show dependency treegraph
 
Reported: 2012-03-22 06:31 PDT by Ian Moody [:Kwan]
Modified: 2012-05-20 20:35 PDT (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Fix errors in the test (2.95 KB, patch)
2012-03-22 06:31 PDT, Ian Moody [:Kwan]
dao+bmo: review+
Details | Diff | Splinter Review

Description Ian Moody [:Kwan] 2012-03-22 06:31:02 PDT
Work in bug 737792 showed up some errors in the test file browser_bug329212.js with misplaced brackets causing the error message to be inside the expression and thus not show up.
Comment 1 Ian Moody [:Kwan] 2012-03-22 06:31:15 PDT
Created attachment 608316 [details] [diff] [review]
Fix errors in the test

This fixes the errors in the test, moving misplaced brakets so the error message is an argument for ok() and not the function in the expression.  Also changed an ok(foo != bar) to isnot(foo, bar).
Comment 2 Dão Gottwald [:dao] 2012-03-22 07:17:30 PDT
Comment on attachment 608316 [details] [diff] [review]
Fix errors in the test

Thanks!
Comment 3 Ian Moody [:Kwan] 2012-03-22 14:45:57 PDT
Comment on attachment 608316 [details] [diff] [review]
Fix errors in the test

Hmm, bzexport didn't update the patch description, so whoever checks it in will have to add the bug number & description.
Comment 5 Ed Morley [:emorley] 2012-03-24 13:57:14 PDT
https://hg.mozilla.org/mozilla-central/rev/8889d78513a7

Note You need to log in before you can comment on or make changes to this bug.