738356 - Add JSAPI for binding functions

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Boris Zbarsky [:bzbarsky]]

I want this for bug 726949.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Add JSAPI for doing the equivalent of Function.prototype.bind.

Comment 2

[Jason Orendorff [:jorendorff]]

Comment on attachment 608590 [details] [diff] [review]
Add JSAPI for doing the equivalent of Function.prototype.bind.

Looks good.

Please change the functions JS_BindCallable and js_fun_bind to have return type JSObject * rather than an out parameter.

Can we have a jsapi-test? See js/src/jsapi-tests/README.

Comment 3

[Boris Zbarsky [:bzbarsky]]

> Please change the functions JS_BindCallable and js_fun_bind to have return type 
> JSObject* rather than an out parameter.

And use an out param boolean to communicate failure state?  That seems odd for the JS engine...

> Can we have a jsapi-test?

Probably, once I have time to work on this again.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Per irc comments, just use NULL return to indicate failure.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Updated to comments, no tests yet

Comment 6

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/mozilla-central/rev/f381c497e47a with JSAPI test.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Er, https://hg.mozilla.org/integration/mozilla-inbound/rev/f381c497e47a

Comment 8

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/f381c497e47a