738551 - SVG SMIL: Don't animate transform attribute with set, animate etc.

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Brian Birtles (:birtles)]

Attachment: Test case

According to http://www.w3.org/TR/SVG11/animate.html#AnimationAttributesAndProperties, <transform-list> is only animatable with <animateTransform>. However, according to the test case in the URL, we allow targetting it with <set>. It appears we just assume the type of the transform is "translate".

I note in nsSVGElement::GetAnimatedAttr we return the transform attribute (wrapped up as a nsISMILAttr) indiscriminately of what kind of animation element is requesting it.

Comment 1

[Robert Longson [:longsonr]]

Attachment: patch

Comment 2

[Robert Longson [:longsonr]]

An alternative would be to move nsSMILCSSProperty::IsPropertyAnimatable into nsSVGAnimationElement and override it for nsSVGAnimateTransformElement.

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 706794 [details] [diff] [review]
patch

I like your proposed fix better than your proposed alternative-fix. (Bringing IsPropertyAnimatable into the mix would confuse things, IIUC, because it's supposed to be css-property-specific.)

Comment 4

[Robert Longson [:longsonr]]

https://tbpl.mozilla.org/?tree=Try&rev=c65daeb32b48

Comment 5

[Robert Longson [:longsonr]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2d20659b4ad3

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/2d20659b4ad3