SVG SMIL: Don't animate transform attribute with set, animate etc.

RESOLVED FIXED in mozilla21

Status

()

Core
SVG
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: birtles, Assigned: longsonr)

Tracking

Trunk
mozilla21
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

(Reporter)

Description

6 years ago
Created attachment 608602 [details]
Test case

According to http://www.w3.org/TR/SVG11/animate.html#AnimationAttributesAndProperties, <transform-list> is only animatable with <animateTransform>. However, according to the test case in the URL, we allow targetting it with <set>. It appears we just assume the type of the transform is "translate".

I note in nsSVGElement::GetAnimatedAttr we return the transform attribute (wrapped up as a nsISMILAttr) indiscriminately of what kind of animation element is requesting it.
(Assignee)

Comment 1

5 years ago
Created attachment 706794 [details] [diff] [review]
patch
Assignee: nobody → longsonr
Attachment #706794 - Flags: review?(dholbert)
(Assignee)

Comment 2

5 years ago
An alternative would be to move nsSMILCSSProperty::IsPropertyAnimatable into nsSVGAnimationElement and override it for nsSVGAnimateTransformElement.
Comment on attachment 706794 [details] [diff] [review]
patch

I like your proposed fix better than your proposed alternative-fix. (Bringing IsPropertyAnimatable into the mix would confuse things, IIUC, because it's supposed to be css-property-specific.)
Attachment #706794 - Flags: review?(dholbert) → review+
(Assignee)

Comment 4

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=c65daeb32b48
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d20659b4ad3
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/2d20659b4ad3
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.