Closed Bug 738554 Opened 8 years ago Closed 8 years ago

Some robocop tests have race conditions that could result in timeouts

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 14
Tracking Status
firefox13 --- fixed
firefox14 --- fixed

People

(Reporter: kats, Assigned: kats)

Details

Attachments

(1 file)

Attached patch Fix racesSplinter Review
A couple of the tests start listening for events after they might already have happened, which would result in the test hanging and manifest as timeouts.
Attachment #608613 - Flags: review?(mark.finkle)
Comment on attachment 608613 [details] [diff] [review]
Fix races

Thanks
Attachment #608613 - Flags: review?(mark.finkle) → review+
Will land if the try run is good. I totally didn't test this patch :)

https://tbpl.mozilla.org/?tree=Try&rev=9107e0e35a4e
Try run was "good" in that it didn't start failing more than it already was. Not that that's saying much. Landed on inbound.

https://hg.mozilla.org/integration/mozilla-inbound/rev/13cf485e1d1c
Target Milestone: --- → Firefox 14
https://hg.mozilla.org/mozilla-central/rev/13cf485e1d1c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.