738554 - Some robocop tests have race conditions that could result in timeouts

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Fix races

A couple of the tests start listening for events after they might already have happened, which would result in the test hanging and manifest as timeouts.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 608613 [details] [diff] [review]
Fix races

Thanks

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Will land if the try run is good. I totally didn't test this patch :)

https://tbpl.mozilla.org/?tree=Try&rev=9107e0e35a4e

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Try run was "good" in that it didn't start failing more than it already was. Not that that's saying much. Landed on inbound.

https://hg.mozilla.org/integration/mozilla-inbound/rev/13cf485e1d1c

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/13cf485e1d1c

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/882fc7645a59

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Mark Finkle (:mfinkle) from comment #5)
> https://hg.mozilla.org/releases/mozilla-aurora/rev/882fc7645a59

Wrong!

https://hg.mozilla.org/releases/mozilla-aurora/rev/932cf6043b9b