Some robocop tests have race conditions that could result in timeouts

RESOLVED FIXED in Firefox 13

Status

()

Firefox for Android
General
RESOLVED FIXED
5 years ago
10 months ago

People

(Reporter: kats, Assigned: kats)

Tracking

unspecified
Firefox 14
All
Android
Points:
---

Firefox Tracking Flags

(firefox13 fixed, firefox14 fixed)

Details

Attachments

(1 attachment)

Created attachment 608613 [details] [diff] [review]
Fix races

A couple of the tests start listening for events after they might already have happened, which would result in the test hanging and manifest as timeouts.
Attachment #608613 - Flags: review?(mark.finkle)
Comment on attachment 608613 [details] [diff] [review]
Fix races

Thanks
Attachment #608613 - Flags: review?(mark.finkle) → review+
Will land if the try run is good. I totally didn't test this patch :)

https://tbpl.mozilla.org/?tree=Try&rev=9107e0e35a4e
Try run was "good" in that it didn't start failing more than it already was. Not that that's saying much. Landed on inbound.

https://hg.mozilla.org/integration/mozilla-inbound/rev/13cf485e1d1c
Target Milestone: --- → Firefox 14
https://hg.mozilla.org/mozilla-central/rev/13cf485e1d1c
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
https://hg.mozilla.org/releases/mozilla-aurora/rev/882fc7645a59
status-firefox13: --- → fixed
status-firefox14: --- → fixed
(In reply to Mark Finkle (:mfinkle) from comment #5)
> https://hg.mozilla.org/releases/mozilla-aurora/rev/882fc7645a59

Wrong!

https://hg.mozilla.org/releases/mozilla-aurora/rev/932cf6043b9b
You need to log in before you can comment on or make changes to this bug.