Closed Bug 738605 Opened 12 years ago Closed 12 years ago

JavaScript strict warning in menulist.xml

Categories

(Toolkit :: UI Widgets, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: neil, Assigned: ananuti)

References

Details

(Whiteboard: [mentor=Neil][lang=js])

Attachments

(1 file)

Warning: useless expression
Source File: chrome://global/content/bindings/menulist.xml
Line: 389
Source Code:
>            <!-- Droppable is currently used for the Firefox bookmarks dialog only -->

Someone put an XML comment inside a CDATA block...
Attached patch patchSplinter Review
Attachment #608676 - Flags: review?(neil)
Attachment #608676 - Flags: review?(neil) → review+
Comment on attachment 608676 [details] [diff] [review]
patch

need checkin
Attachment #608676 - Flags: checkin?
Assignee: nobody → ananuti
Status: NEW → ASSIGNED
Comment on attachment 608676 [details] [diff] [review]
patch

You don't need to use checkin?. Just set checkin-needed on the whiteboard like Neil did.
Attachment #608676 - Flags: checkin?
https://hg.mozilla.org/integration/mozilla-inbound/rev/df884799ad23
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/df884799ad23
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: