Closed
Bug 738607
Opened 13 years ago
Closed 13 years ago
JavaScript strict warning in tabmail.xml
Categories
(SeaMonkey :: MailNews: General, defect)
SeaMonkey
MailNews: General
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.11
People
(Reporter: neil, Assigned: sgautherie)
References
Details
Attachments
(1 file)
Warning: function onEvent does not always return a value
Source File: chrome://messenger/content/tabmail.xml
Line: 899
Source:
return onEventFunc.call(tabInfo.mode.tabType,
Like doCommandFunc, onEventFunc isn't supposed to return a value.
Also, the if (!ttabinfo) check above looks suspicious.
|
Assignee | |
Comment 1•13 years ago
|
||
|
|
Assignee | |
Updated•13 years ago
|
Flags: in-testsuite-
Keywords: helpwanted
Whiteboard: [mentor=Neil][lang=js]
Target Milestone: --- → seamonkey2.11
|
Reporter | |
Comment 2•13 years ago
|
||
Comment on attachment 608954 [details] [diff] [review]
(Av1) tabmail.xml: Fix 'ttabInfo' typo and JavaScript strict warning in onEvent()
[Checked in: Comment 3]
I wonder why Mnyromyr wrapped the call for doCommandFunc...
Attachment #608954 -
Flags: review?(neil) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Comment on attachment 608954 [details] [diff] [review]
(Av1) tabmail.xml: Fix 'ttabInfo' typo and JavaScript strict warning in onEvent()
[Checked in: Comment 3]
http://hg.mozilla.org/comm-central/rev/3ced8f9ed8d7
Attachment #608954 -
Attachment description: (Av1) tabmail.xml: Fix 'ttabInfo' typo and JavaScript strict warning in onEvent() → (Av1) tabmail.xml: Fix 'ttabInfo' typo and JavaScript strict warning in onEvent()
[Checked in: Comment 3]
|
|
Assignee | |
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•