738662 - Add tracing/warning information to help debug XUL overlay problems

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[:Irving Reid (No longer working on Firefox)]

While trying to track down some overlay-related issues, I added useful details to several error and warning messages. Most of these only come out with NSPR_LOG_MODULES=nsXULDocument:4, but it's better than nothing.

Comment 1

[:Irving Reid (No longer working on Firefox)]

Attachment: Add details to various error/warning messages

"File Not Found" is so much nicer when it actually tells you *which* file...

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 608765 [details] [diff] [review]
Add details to various error/warning messages

Instead of hand-unrolling the NS_WARNING in PutScript, just dynamically construct the string for it, please (#ifdef DEBUG, of course).

The changes to nsExpatDriver::HandleExternalEntityRef are wrong; that function doesn't return nsresult, so returning rv is broken.

The rest looks fine, though the toolkit change should get review from someone who knows that code.

Comment 3

[:Irving Reid (No longer working on Firefox)]

Attachment: Add details to various error/warning messages, take 2

Addressed bz's comments, added enndeakin to review XUL toolkit change.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 608797 [details] [diff] [review]
Add details to various error/warning messages, take 2

r=me

Comment 5

[Neil Deakin]

Comment on attachment 608797 [details] [diff] [review]
Add details to various error/warning messages, take 2

>+            if (!toolbox) {
>+              let tbName = this.getAttribute("toolbarName");

This should be 'toolbarname' (all lowercase) or this.toolbarName

>+              throw("toolbar ID " + this.getAttribute("id") + tbname + ": toolboxid attribute '" + toolboxId + "' points to a toolbox which doesn't exist");

Use this.id and print a space between the id and the name.

Comment 6

[:Irving Reid (No longer working on Firefox)]

Attachment: Add details to various error/warning messages, take 3

Clean up toolbox.xml comments from Neil Deakin.

If toolbarName isn't null, the tbName string is built with a leading space so I don't add one in the throw().

Comment 7

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/2f58de36c53a

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2f58de36c53a